Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Terminology and Clarity in Documentation #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve Terminology and Clarity in Documentation #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf54c3
Update pull_request_template.md
Hopium21 Jan 30, 2025
19879ce
Update prod-test.yml
Hopium21 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This pr adds user login function, includes：
<!-- The test plan section indicates detailed steps on how to verify and test code changes.
You can list the test cases or test steps that need to be performed.-->
Example:
- 1. Use different test accounts for login tests, including correct user names and passwords, and incorrect user names and passwords.
- 1. Use different test accounts for login tests, including correct usernames and passwords, and incorrect usernames and passwords.
- 2. ...

## Related Issue
Expand All @@ -21,4 +21,4 @@ Example: Issue #123
## Notes
<!-- The Important Matters section can alert others to special requirements or matters that need extra attention -->

- Example: Links and navigation need to be added to the front-end interface
- Example: Links and navigation need to be added to the front-end interface
6 changes: 3 additions & 3 deletions .github/workflows/prod-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ jobs:
name: Push Slack Notification
uses: storyprotocol/gha-workflows/.github/workflows/reusable-slack-notifs.yml@main
with:
short-desc: "${{ github.repository }}: API Integration Tests of Prod have been completed. Check the results at https://storyprotocol.github.io/api-integration-tests/index.html"
title: "API Integration Test Results of Prod"
short-desc: "${{ github.repository }}: API Integration Tests for Prod have been completed. Check the results at https://storyprotocol.github.io/api-integration-tests/index.html"
title: "API Integration Test Results for Prod"
img-url: "http://www.quickmeme.com/img/b9/b9848df257b95cd39585368475a4b4e4a3a8c774f7390226daecb79b912087ad.jpg"
img-alt-text: "API Integration Test Results"
secrets:
channel-name: ${{ secrets.SLACK_CHANNEL_ID_API_INTEGRATION_TESTS }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}