Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: penumbra ics-20 test cases #1157

Merged
merged 69 commits into from
Jul 14, 2024
Merged

feat: penumbra ics-20 test cases #1157

merged 69 commits into from
Jul 14, 2024

Conversation

zbuc
Copy link
Contributor

@zbuc zbuc commented Jun 25, 2024 •
edited
Loading

Description

This PR finishes work started in #837 to introduce tests for Penumbra, both for Penumbra <-> Penumbra and Penumbra <-> Cosmos cases, exercising both successful transfers and timeouts based on height and timestamp in both directions.

How to test

$ go test -v -race ./examples/penumbra/penumbra_ibc_test.go

Additional Information

This requires some changes to Penumbra that haven't landed in a release yet. When the next release for Penumbra lands, a new image should be pushed out through Heighliner. Otherwise, to test against the current Penumbra main branch you can modify the configuredChains.yaml as follows:

penumbra:
  name: penumbra
  type: penumbra
  bin: cometbft
  bech32-prefix: penumbrav2t
  denom: upenumbra
  gas-prices: 0.0upenumbra
  gas-adjustment: 2.0
  trusting-period: 672h
  images:
    - repository: ghcr.io/strangelove-ventures/heighliner/cometbft
      uid-gid: 1025:1025
    - repository: penumbra
      uid-gid: 1025:1025

And build a local tagged version of the Penumbra image with Heighliner:

$ heighliner build -c penumbra -o penumbra-zone -g main -t local

jtieri and others added 30 commits September 25, 2023 11:45
@jtieri
test: working on penumbra<>penumbra ibc test case
75c58e4
@jtieri
test: use proper chain for second test user
dd2f374
@jtieri
wip: update to penumbra v0.61.0 and build out ibc support
68e1f56
@jtieri
change tendermint to cometbft in rel path
b5609f3
@jtieri
update penumbra and cometbft versions in test case and change flag
817d7f0
@jtieri
Merge branch 'main' into justin/penumbra-ibc
d58fb8f
@jtieri
proto: update penumbra protos to v0.62.0
68f5f79
@jtieri
chore: go mod tidy
ace0455
@jtieri
chore: remove debug output & implement ics2_withdrawal support
90a8a50
@jtieri
test: update network integration test
7fb8ff4
@jtieri
test: implement ics_20 transfer tests
4c1cb6b
@jtieri
test: update penumbra to v0.62.0 and cometbft to v0.37.0
42406e2
@jtieri
test: fall back to pcli ics20 withdrawal while debugging
575934d
@jtieri
chore: update penumbra protos
8fe1a8d
@jtieri
fix: adjust pcli cmd for generating keys and config.toml + make prope…
6c7c2b9 
…r use of cli args
@jtieri
test: update penumbra version to v0.63.3
9348931
@jtieri
fix: remove unnecessary field usage in protos
1288bbb
@jtieri
fix: properly parse the fvk and custody key from pcli instances
6e49daf
@jtieri
fix: generate keys from mnemonics properly
ed02d7d
@jtieri
chore: remove commented out code & debug output
b384627
@jtieri
chore: execute ics_20 withdrawals from pclientd instead of pcli
21db920
@jtieri
chore: remove debug output
a7dce98
@jtieri
test: update penumbra to v0.64.1, remove debug output, pass in valid …
c71b6d1 
…ics_20 transfer timeout timestamp
@jtieri
Merge branch 'main' into justin/penumbra-ibc
31f1a05
@jtieri
chore: update go.work.sum
20d5e1f
@jtieri
test: use math.Int instead of int64 where necessary
1bdb93e
@jtieri
chore: check errors that were previously being ignored
dc52a6f
@jtieri
Merge branch 'main' into justin/penumbra-ibc
0ea3610 
# Conflicts:
#	go.work.sum
@jtieri
chore: update go.work.sum
55787f5
@jtieri
Add documentation comments to Penumbra-related code.
808531b 
This commit extends the Go documentation of the Penumbra-related types, state, and behaviors found across the entire codebase. A significant part of this update focuses on the structs and functions in Penumbra's chain logic and client node, as well as the related helpers and tests. These comments should make the purpose and functionality of the code more transparent and understandable for further development and usage.
@zbuc zbuc requested a review from a team as a code owner June 25, 2024 22:14
@zbuc zbuc requested a review from pharr117 June 25, 2024 22:14
@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2024 7:29am

@Reecepbcups Reecepbcups changed the title Interchain Tests for Penumbra feat: penumbra ics-20 test cases Jun 26, 2024
@zbuc zbuc force-pushed the chris/penumbra-ibc branch from 665b638 to dfa435b Compare June 26, 2024 19:00
@zbuc zbuc force-pushed the chris/penumbra-ibc branch from dfa435b to 41c2aaa Compare June 26, 2024 19:01
@Reecepbcups Reecepbcups mentioned this pull request Jun 26, 2024
Merged
@zbuc
Copy link
Contributor Author

zbuc commented Jun 26, 2024

@Reecepbcups I verified the tests still pass after updating the Docker images (41c2aaa)

Looks like CI is failing because of some lint failures unrelated to changes from this PR

@Reecepbcups
Copy link
Member

Reecepbcups commented Jun 26, 2024 •
edited
Loading

Amazing thank you! It will take me a bit to review this & I am out tomorrow, but one of the top things on my list :)

I'll get lint issues and minor things like that sorted out later after I run through it all

Reecepbcups
Reecepbcups reviewed Jun 28, 2024
View reviewed changes
examples/penumbra/penumbra_chain_test.go Show resolved Hide resolved
chain/penumbra/penumbra_app_node.go Show resolved Hide resolved
chain/penumbra/penumbra_app_node.go Outdated Show resolved Hide resolved
chain/penumbra/penumbra_app_node.go Show resolved Hide resolved
chain/penumbra/penumbra_chain.go Show resolved Hide resolved
chain/penumbra/penumbra_client_node.go Show resolved Hide resolved
chain/penumbra/penumbra_client_node.go Outdated Show resolved Hide resolved
chain/penumbra/penumbra_client_node.go Show resolved Hide resolved
chain/penumbra/penumbra_client_node.go Outdated Show resolved Hide resolved
@Reecepbcups Reecepbcups mentioned this pull request Jun 28, 2024
Merged
@jtieri jtieri mentioned this pull request Jul 3, 2024
Closed
Reecepbcups
Reecepbcups approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@Reecepbcups Reecepbcups left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Looks great! Thank you so much

Getting into mainline, will tag a new ICTest release in the near future to make it easy for others to upgrade to

@Reecepbcups Reecepbcups merged commit 5c5b565 into strangelove-ventures:main Jul 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@pharr117 pharr117 Awaiting requested review from pharr117 pharr117 is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

@jtieri jtieri Awaiting requested review from jtieri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbuc @Reecepbcups @jtieri