fix: correctly check transaction status #886
Conversation
|
@johnletey I am a bit confused, where is there --broadcast-mode= Only reason I suspect this to break is if your test uses I see you are re-decoding the Tx from the original Txhash to get all the data, but only the TxHash is returned so you don't get to use this extra processing |
| if output.Code != 0 { | ||
| return output.TxHash, fmt.Errorf("transaction failed with code %d: %s", output.Code, output.RawLog) | ||
|
|
||
| if err := testutil.WaitForBlocks(ctx, 1, tn); err != nil { |
There was a problem hiding this comment.
| if err := testutil.WaitForBlocks(ctx, 1, tn); err != nil { | |
| if err := testutil.WaitForBlocks(ctx, 2, tn); err != nil { |
|
Closing as the v7 branch matches v8 - SDK v47 and SDK v50 chains work as expected and use the if the issue persist please re-tag me and I will look into it more. The proposed changes here would not resolve that even if broadcast-mode=block was used. |
Starting in the
v0.47.xrelease line, theblockbroadcast mode has been deprecated. I've updated theExecTxlogic to match what the SDK team recommends.