Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Create A Unique Email For Membership Renewals in PMPro #225

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

MaryOJob
Copy link
Contributor

@MaryOJob MaryOJob commented Nov 18, 2024

No description provided.

Copy link
Contributor

@andrewlimaza andrewlimaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires WPCS and correct docblock layout. A nice to have might be a fallback if the file doesn't exist in the email directory to use default text so it doesn't break completely or send empty emails.

Please can you make these adjustments.

@MaryOJob
Copy link
Contributor Author

@andrewlimaza I updated this snippet, wanted to ask too; should we still be adding custom email templates like this or this should be done using the pmproet_templates filter?

@andrewlimaza
Copy link
Contributor

Yes it would be best to add it to the pmproet_templates filter and the linked documentation would need to be updated (once merged in).

@MaximilianoRicoTabo
Copy link
Contributor

Hey @andrewlimaza @MaryOJob what do you think about hooking into
pmpro_send_checkout_emails filter https://github.com/strangerstudios/paid-memberships-pro/blob/v3.4/includes/checkout.php#L299

and then instead of send the checkout email instantiate a new custom renewal class created as a child of PMPro_Email_Template class and send it. A more v3.4 approach. I can test further tomorrow if you think it worths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants