Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fatal errors for sub shortcodes #25

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

derekashauer
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Resolves #22

How to test the changes in this Pull Request:

  1. Use any sub shortcodes out of context (without main shortcode). Example:

[pmpro_testimonials_display_custom]
[pmpro_testimonial_content]
[pmpro_testimonial_rating]

  1. Errors should no longer appear

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Prevent sub shortcodes from showing fatal error when not used in proper context

Prevent inner shortcodes from showing fatal error when not used in proper context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail quietly if pmpro_testimonials_display_custom is not used correctly
1 participant