Add more integration tests for PyAnalyzeLaurel#614
Open
andrewmwells-amazon wants to merge 8 commits intomainfrom
Open
Add more integration tests for PyAnalyzeLaurel#614andrewmwells-amazon wants to merge 8 commits intomainfrom
andrewmwells-amazon wants to merge 8 commits intomainfrom
Conversation
andrewmwells-amazon
requested review from
fabiomadge and
keyboardDrummer
as code owners
shigoel
previously approved these changes
Mar 19, 2026
aqjune-aws
previously approved these changes
Mar 19, 2026
…/Strata into andrewmwells/python_int_tests
andrewmwells-amazon
dismissed stale reviews from aqjune-aws and shigoel
via
fe3fc4f
Contributor
|
Great to have these additions, although I think that when possible, we should prioritize a testing format that interweaves the source code and the diagnostics that the user sees, to make it much easier to review the tests. The current expect files also at most test for source locations instead of source location ranges, so not all the relevant output is being tested. |
aqjune-aws
previously approved these changes
Mar 20, 2026
Contributor
|
It seems there is a conflict - do you want to resolve it? |
aqjune-aws
previously approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more integration tests for PyAnalyzeLaurel
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.