Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestNet] Add Delegatedtransfer method to NonFungibleToken #95

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[TestNet] Add Delegatedtransfer method to NonFungibleToken #95

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9784352
Add DelegatedTransfer method
quantumagi Aug 18, 2023
b560a76
Update testnet
quantumagi Aug 18, 2023
3b1671c
Add comments
quantumagi Aug 18, 2023
1495784
Parse addresses
quantumagi Aug 18, 2023
ea37908
Target only Testnet for now
quantumagi Aug 21, 2023
9b7039a
Add test case
quantumagi Aug 21, 2023
35f75ce
Update references
quantumagi Aug 21, 2023
96becaa
Add serializer
quantumagi Aug 21, 2023
f8b4817
Update address parsing
quantumagi Aug 21, 2023
43948b8
Parse tokenId as normal number
quantumagi Aug 22, 2023
09a4748
Rename action => method
quantumagi Aug 22, 2023
b3033cc
Add contract field to url
quantumagi Aug 23, 2023
eed2bba
Rename getsigner method
quantumagi Aug 29, 2023
37a849c
Update README
quantumagi Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Testnet/NonFungibleToken-Ticket/NonFungibleToken.Tests/NonFungibleTokenTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ public void DelegatedTransfer_ValidTokenTransfer_MessageSender_TransfersTokenFro
var nonFungibleToken = CreateNonFungibleToken();
var uid = Guid.NewGuid();

string url = $"?uid={Convert.ToHexString(uid.ToByteArray().Reverse().ToArray())}&action=DelegatedTransfer&from={this.AddressToString(ownerAddress)}&to={this.AddressToString(targetAddress)}&tokenId=1";
string url = $"?uid={Convert.ToHexString(uid.ToByteArray().Reverse().ToArray())}&method=DelegatedTransfer&from={this.AddressToString(ownerAddress)}&to={this.AddressToString(targetAddress)}&tokenId=1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use uid as string for avoid endian stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rather keep uid compatible with UInt128/Guid,

byte[] signature = Convert.FromBase64String(key.SignMessage(url));

nonFungibleToken.DelegatedTransfer(url, signature);
Expand Down
2 changes: 1 addition & 1 deletion Testnet/NonFungibleToken-Ticket/NonFungibleToken/NonFungibleToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ private struct SignatureTemplate
/// <param name="signature">The signature of the <paramref name="url"/> string signed by the owner.</param>
public void DelegatedTransfer(string url, byte[] signature)
{
string[] args = SSAS.GetURLArguments(url, new string[] { "uid", "action", "from", "to", "tokenId" });
string[] args = SSAS.GetURLArguments(url, new string[] { "uid", "method", "from", "to", "tokenId" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to add contract address here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


Assert(args != null && args.Length == 5 && args[1] == nameof(DelegatedTransfer), "Invalid url.");

Expand Down