Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8> #1442

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Feb 3, 2025

close #1436

loosely inspired by 3f2815b from @Fi3 at #1248, but with a few corrections (and split into two different commits)

note: this renaming only happens on roles_logic_sv2, but not on SRI application layer (roles), where the field remains called pool_signature

@plebhash plebhash added refactor Implies refactoring code protocols Lowest level protocol logic roles-logic-sv2 labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.27%. Comparing base (7dd1846) to head (08b2523).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
roles/jd-client/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   18.28%   18.27%   -0.02%     
==========================================
  Files         127      127              
  Lines        9738     9738              
==========================================
- Hits         1781     1780       -1     
- Misses       7957     7958       +1     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.95% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 24.88% <ø> (ø)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage 0.42% <0.00%> (ø)
jd_server-coverage 12.98% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.38% <ø> (ø)
mining-coverage 3.15% <ø> (-0.03%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 5.78% <ø> (ø)
protocols 23.89% <100.00%> (-0.02%) ⬇️
roles 7.71% <0.00%> (ø)
roles_logic_sv2-coverage 11.62% <100.00%> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.53% <ø> (ø)
utils 25.04% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

this is a more generic name, as this extra data could be used for other things and not only pool signature

note: this renaming only happens on `roles_logic_sv2`, but not on SRI application layer (`roles`), where the field remains called `pool_signature`
@plebhash plebhash force-pushed the rename-pool-signature branch from 5251f81 to 08b2523 Compare February 17, 2025 20:52
@plebhash plebhash merged commit cee44e8 into stratum-mining:main Feb 18, 2025
31 checks passed
@plebhash plebhash deleted the rename-pool-signature branch February 18, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocols Lowest level protocol logic refactor Implies refactoring code roles-logic-sv2
Projects
None yet
2 participants