-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename pool_signature
field of channel_factory
into additional_coinbase_script_data
, and change the type from String
to Vec<u8>
#1442
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 18.28% 18.27% -0.02%
==========================================
Files 127 127
Lines 9738 9738
==========================================
- Hits 1781 1780 -1
- Misses 7957 7958 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
12a8a98
to
be9fd92
Compare
be9fd92
to
5251f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
this is a more generic name, as this extra data could be used for other things and not only pool signature note: this renaming only happens on `roles_logic_sv2`, but not on SRI application layer (`roles`), where the field remains called `pool_signature`
5251f81
to
08b2523
Compare
close #1436
loosely inspired by 3f2815b from @Fi3 at #1248, but with a few corrections (and split into two different commits)
note: this renaming only happens on
roles_logic_sv2
, but not on SRI application layer (roles
), where the field remains calledpool_signature