Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reject auth test from MG and its footprint #1482

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Feb 13, 2025

close #1481

.. Auth rejection is not implemented, this is just testing the feature flag.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.28%. Comparing base (fb9a683) to head (7dd1846).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   18.27%   18.28%   +0.01%     
==========================================
  Files         127      127              
  Lines        9738     9738              
==========================================
+ Hits         1780     1781       +1     
+ Misses       7958     7957       -1     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.95% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 24.88% <ø> (?)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage 0.42% <ø> (ø)
jd_server-coverage 12.98% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.38% <ø> (ø)
mining-coverage 3.17% <ø> (+0.02%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 5.78% <ø> (ø)
protocols 23.91% <ø> (+0.01%) ⬆️
roles 7.71% <ø> (ø)
roles_logic_sv2-coverage 11.62% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.53% <ø> (ø)
utils 25.04% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn... What's the purpose of this test then? Is it just to check whether OpenMiningChannel.Error is received? That seems pretty vague.

@plebhash
Copy link
Collaborator

Damn... What's the purpose of this test then? Is it just to check whether OpenMiningChannel.Error is received? That seems pretty vague.

it was introduced via 84a3ddb

perhaps a deep inspection of this commit could give us some insights?

@GitGab19
Copy link
Collaborator

Damn... What's the purpose of this test then? Is it just to check whether OpenMiningChannel.Error is received? That seems pretty vague.

it was introduced via 84a3ddb

perhaps a deep inspection of this commit could give us some insights?

Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented..
I think we should add a proper test in the future, as soon as we will have some kind of auth system in place on the Pool.

ACK to remove it for now.

@plebhash plebhash added the ready-to-be-merged triggers auto rebase bot label Feb 17, 2025
.. Auth rejection is not implemented, this is just testing the feature
flag.
@pavlenex pavlenex force-pushed the 2025-02-13/remove-reject-auth branch from afc1f3e to 7dd1846 Compare February 17, 2025 16:16
@plebhash plebhash merged commit 72d3e57 into stratum-mining:main Feb 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-be-merged triggers auto rebase bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pool-sri-reject-auth MG test
4 participants