-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reject auth test from MG and its footprint #1482
Remove reject auth test from MG and its footprint #1482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
+ Coverage 18.27% 18.28% +0.01%
==========================================
Files 127 127
Lines 9738 9738
==========================================
+ Hits 1780 1781 +1
+ Misses 7958 7957 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn... What's the purpose of this test then? Is it just to check whether OpenMiningChannel.Error
is received? That seems pretty vague.
it was introduced via 84a3ddb perhaps a deep inspection of this commit could give us some insights? |
Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented.. ACK to remove it for now. |
.. Auth rejection is not implemented, this is just testing the feature flag.
afc1f3e
to
7dd1846
Compare
close #1481
.. Auth rejection is not implemented, this is just testing the feature flag.