Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool config struct changes #1493

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Feb 18, 2025

addresses #1260 and other changes

Need to complete:

  • Document pool/src/config.rs

@jbesraa jbesraa changed the title 2025 02 18/pool config pool config struct changes Feb 18, 2025
@GitGab19 GitGab19 marked this pull request as draft February 18, 2025 14:46
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 17.06%. Comparing base (bec1d3e) to head (7d05c4e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
roles/pool/src/lib/config.rs 35.29% 11 Missing ⚠️
roles/pool/src/lib/mining_pool/mod.rs 28.57% 5 Missing ⚠️
roles/pool/src/lib/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   18.28%   17.06%   -1.23%     
==========================================
  Files         127      140      +13     
  Lines        9738    10569     +831     
==========================================
+ Hits         1781     1804      +23     
- Misses       7957     8765     +808     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.95% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 24.88% <ø> (ø)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage 0.42% <ø> (ø)
jd_server-coverage 12.98% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.38% <ø> (ø)
mining-coverage 3.17% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 5.78% <ø> (ø)
pool_sv2-coverage 2.45% <30.76%> (?)
protocols 23.91% <ø> (ø)
roles 6.75% <30.76%> (-0.96%) ⬇️
roles_logic_sv2-coverage 11.62% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.53% <ø> (ø)
utils 25.04% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbesraa jbesraa force-pushed the 2025-02-18/pool-config branch from 7cec80f to 7d05c4e Compare February 19, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant