fix(json-patch-ot): bug when transforming str_del with len#810
Merged
streamich merged 1 commit intostreamich:masterfrom Feb 5, 2025
Merged
fix(json-patch-ot): bug when transforming str_del with len#810streamich merged 1 commit intostreamich:masterfrom
streamich merged 1 commit intostreamich:masterfrom
Conversation
|
🎉 This PR is included in version 17.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug when using json-patch-ot with str_del.len instead of str_del.str operations.
Added the same transformations using len instead of str in scenarios.spec.ts.
The test failing before was:
"str_del x str_del (with str_del.len)" ->"Deletes at higher position partially overlapping."