Skip to content

Commit

Permalink
fix: Replace logical property for overflow on <body>
Browse files Browse the repository at this point in the history
Also remove old additions for IE CSS grid
  • Loading branch information
NicolaSaunders committed Jan 30, 2024
1 parent a06127c commit 85344cc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
7 changes: 2 additions & 5 deletions assets-src/styles/sass/30-base/_body.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
1. Prevent font size inflation with change of orientation
2. Needed for sticky footer
3. Because autoprefixer does not cover IE grid
3. Equivalent `overflow-inline` logical property not currently well supported
\*------------------------------------*/

html {
Expand All @@ -21,13 +21,10 @@ body {
background-color: $off-white;
color: $off-black;
display: grid; /* 2 */
display: -ms-grid; /* 3 */
grid-template-columns: 100%;
-ms-grid-columns: 100%; /* 3 */
grid-template-rows: 1fr auto; /* 2 */
-ms-grid-rows: 1fr auto; /* 3 */
min-block-size: 100%;
overflow-inline: hidden;
overflow-x: hidden; /* 3 */
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
}
7 changes: 2 additions & 5 deletions web/dist/styles/core.css
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ article {
1. Prevent font size inflation with change of orientation
2. Needed for sticky footer
3. Because autoprefixer does not cover IE grid
3. Equivalent `overflow-inline` logical property not currently well supported
\*------------------------------------*/
html {
block-size: 100%;
Expand All @@ -202,13 +202,10 @@ body {
background-color: #fcfcfc;
color: #252525;
display: grid; /* 2 */
display: -ms-grid; /* 3 */
grid-template-columns: 100%;
-ms-grid-columns: 100%; /* 3 */
grid-template-rows: 1fr auto; /* 2 */
-ms-grid-rows: 1fr auto; /* 3 */
min-block-size: 100%;
overflow-inline: hidden;
overflow-x: hidden; /* 3 */
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
}
Expand Down
Loading

0 comments on commit 85344cc

Please sign in to comment.