Exclusive file lock during cmd execution and some bugs. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIvanchev
changed the title
|
@dmb2, @MIvanchev this PR brokes support of non-Linux systems which may not have |
catap
added a commit
to catap/stumpwm-contrib
that referenced
this pull request
Nov 29, 2024
This fixes regression which was introduced by stumpwm#296
|
@catap What's an alternative for OpenBSD? I.e. can you modify the script with OpenBSD specific stuff? IMHO this change is significant. |
|
@MIvanchev I just did, see #298 |
|
@catap I checked it out, I think it's better to do it outside of the while loop, the loop only makes sense if you want to nagivate the proc chain up when |
|
@MIvanchev maybe rewrite it to https://www.man7.org/linux/man-pages/man1/pgrep.1.html ? |
|
@catap посмотрим! |
catap
added a commit
to catap/stumpwm-contrib
that referenced
this pull request
Nov 30, 2024
Seems that `pgrep` exists everywhere, for example in Debian it is installed from the same package which installs `ps` and `kill`. Use it as main way to detect stumpwm, and old code via /proc as a fallback when no `pgrep` here. This fixes regression which was introduced by stumpwm#296 Co-authored-by: Mihail Ivanchev <[email protected]>
catap
added a commit
to catap/stumpwm-contrib
that referenced
this pull request
Nov 30, 2024
Seems that `pgrep` exists everywhere, for example in Debian it is installed from the same package which installs `ps` and `kill`. Use it as main way to detect stumpwm, and old code via /proc as a fallback when no `pgrep` here. This fixes regression which was introduced by stumpwm#296 Co-authored-by: Mihail Ivanchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is to ensure that stumpish only runs commands with an exclusive file lock and verifies that there is actually a StumpWM process running. There are a lot of issues with stumpish and it requires an overhaul but it's a beginning.