[C#] Fix for loops#4530
Merged
Merged
Conversation
This commit fixes issues with multiple variable declarations in for loops.
keith-hall
approved these changes
Apr 20, 2026
| - maybe_pointer | ||
| - match: (?=;|\)|\}) | ||
| pop: 1 | ||
| for_increment: |
Collaborator
There was a problem hiding this comment.
Technically there is no need for it to be an increment expression, but naming is hard and it is clear enough from looking at this context that it supports decrements etc as well
Collaborator
Author
There was a problem hiding this comment.
Agree, but this is only a quick fix. I have already identified (and partly fixed) dozens of issues, all of which is part of a larger changeset. It needs some time to mature first in order to limit noise.
michaelblyons
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4527
This PR fixes issues with multiple variable declarations in for loops.