[Python] Adjust type patterns#4541
Merged
Merged
Conversation
This commit teaches Python to scope identifiers `variable.other` instead of `support.class` if they contain underscore to reduce chance of false positives. Note: Classes still may start with underscore.
This is a formal change, not affecting syntax behavior.
Scope single uppercase letter tokens, variable.other. May help to reduce false positives and is not semantically wrong with regards to generics.
keith-hall
previously approved these changes
May 2, 2026
FichteFoll
reviewed
May 2, 2026
This reverts commit f6887ba.
FichteFoll
approved these changes
May 3, 2026
jrappen
approved these changes
May 3, 2026
keith-hall
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4540
This PR restricts which tokens are scoped
support.class.Scope tokens as type only, if they
PascalCaseor_PascalCasewithout underscores in between.3. do not end with uppercase letterSingle char upper case tokens are now scoped
variable.other, which is probably an appropriate scope for "type variables" in generics as well.It would be possible to keep them scoped
support.typein type annotations with further adjustments to related contexts. Those currently use normal expression rules, which causes some ambiguities to resolve - especially with regards toafter-expressioncontext.