Skip to content

Take over Indent XML#9412

Open
braver wants to merge 1 commit into
masterfrom
braver-patch-xml
Open

Take over Indent XML#9412
braver wants to merge 1 commit into
masterfrom
braver-patch-xml

Conversation

@braver
Copy link
Copy Markdown
Collaborator

@braver braver commented May 6, 2026

  • I'm the package's author and/or maintainer.
  • I have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. (It already had a few in previous versions, they stay)
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

This points Indent XML to my fork at https://github.com/braver/IndentXML. The original repo hasn't been updated in 8 years, has several issues and PR's without responses, including mine to make it compatible with ST's upcoming move to python 3.14: alek-sys/sublimetext_indentxml#131.

@braver braver requested a review from FichteFoll May 6, 2026 18:29
@braver braver added awaiting objection Awaiting objection from a current maintainer for removal or replacement takeover Package ownership is changing labels May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR changes Indent XML.

Review for Indent XML master-627a6ac-2026.05.06.18.24.24

- Tip of master is tagged with 1.0.1. ✅

No failures

1 warning:
- 'Main.sublime-menu' has no 'Package Settings' entry for key bindings of 'Indent XML'
    File: Main.sublime-menu


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

Repository: https://github.com/braver/IndentXML

@braver
Copy link
Copy Markdown
Collaborator Author

braver commented May 6, 2026

@alek-sys I intend to continue supporting your package at the new repo. Let us know if you object to this.

@braver
Copy link
Copy Markdown
Collaborator Author

braver commented May 6, 2026

📦

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR changes Indent XML.

Review for Indent XML master-3de5b51-2026.05.06.18.32.13

- Tip of master is tagged with 1.0.2. ✅

1 failure:
- 'Main.sublime-menu' has a 'Key Bindings' entry whose 'args.base_file' does not exist: ${packages}/Indent XML/Default ($platform).sublime-keymap
    File: Main.sublime-menu

No warnings


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

Repository: https://github.com/braver/IndentXML

@braver
Copy link
Copy Markdown
Collaborator Author

braver commented May 6, 2026

Not sure what the test is all about, the file is there: https://github.com/braver/IndentXML/blob/master/Default%20(OSX).sublime-keymap

@FichteFoll
Copy link
Copy Markdown
Collaborator

I assume not forking the package was deliberate in order to not mess up merge requests for the fork network being made against the root repository? In that case, a reference to the original package in the README would be appreciated.

Other than that, I really didn't look much into. LGTM after the 2-week grace period.

@braver
Copy link
Copy Markdown
Collaborator Author

braver commented May 7, 2026

I assume not forking the package was deliberate in order to not mess up merge requests for the fork network being made against the root repository?

Indeed. That gets really old real quick if you don't actually really intend to contribute back. I'm going to wait out the 2 weeks and do a pass on documentation and credits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting objection Awaiting objection from a current maintainer for removal or replacement takeover Package ownership is changing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants