Skip to content

Add Serendipity and Sequoia color schemes#9436

Merged
braver merged 2 commits into
sublimehq:masterfrom
michael-andreuzza:add-serendipity-sequoia-themes
Jun 1, 2026
Merged

Add Serendipity and Sequoia color schemes#9436
braver merged 2 commits into
sublimehq:masterfrom
michael-andreuzza:add-serendipity-sequoia-themes

Conversation

@michael-andreuzza

Copy link
Copy Markdown
Contributor

Summary

Both repos have tagged release v1.0.0 and .gitattributes excluding README/LICENSE from the package archive.

Checklist

  • I'm the package's author and/or maintainer.
  • I have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README.
  • My package doesn't add context menu entries.
  • My package doesn't add key bindings.
  • If my package is a syntax it doesn't also add a color scheme.
  • I use .gitattributes to exclude files from the package.

My package is a color scheme collection ported from the Serendipity / Sequoia VS Code theme families.

There are no packages like it in Package Control under these names.

Made with Cursor

@github-actions

Copy link
Copy Markdown
Contributor

This PR adds Sequoia Theme and Serendipity Theme.

Review for Sequoia Theme main-19d7612-2026.05.25.14.53.26

No failures

1 warning:

  • The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

Review for Serendipity Theme main-fa612e5-2026.05.25.14.53.23

No failures

1 warning:

  • The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@braver

braver commented May 27, 2026

Copy link
Copy Markdown
Collaborator

If you're targeting Sublime Text, use the sublime-color-scheme format instead of the ancient tmTheme xml format. It's so much easier to work with. Sublime Text can also convert your color scheme to that new format for you.

@braver

braver commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Your color schemes are also very limited, to the point where I wonder if they're fully functional (ie. if Sublime needs to make up all the missing colors). Have a good look at the documentation I linked to.

Finally, looks like you've formatted the entire file... try adding just your entries and in correct alphabetical order.

@braver braver added the feedback provided The changes and package have been seen by a reviewer label May 27, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@michael-andreuzza michael-andreuzza force-pushed the add-serendipity-sequoia-themes branch from 1756f6f to 5ef9ec6 Compare May 30, 2026 06:54
@michael-andreuzza

Copy link
Copy Markdown
Contributor Author

Thanks for the review @braver — all three points addressed:

  1. Format — both packages now ship .sublime-color-scheme (JSON) files instead of the legacy .tmTheme XML.
  2. Completeness — each scheme now has a full set of scope rules (keywords, storage, functions, variables, types, tags/attributes, punctuation, markup/Markdown, diff, invalid) plus proper UI globals (line highlight, gutter, guides, selection borders, brackets, find highlight, minimap, etc.), so Sublime no longer has to synthesize missing colors.
  3. Channel index — reverted the accidental whole-file reformat; the diff is now just the two new entries, placed in correct alphabetical order between SequentialBuilder and SerializedDataConverter.

Both repos are re-tagged at v2.0.0, and the LICENSE now ships inside the package (clears the reviewer-bot warning).

@github-actions

Copy link
Copy Markdown
Contributor

This PR adds Sequoia Theme and Serendipity Theme.

Review for Sequoia Theme main-18e523b-2026.05.30.06.53.48

No failures, no warnings. 👍

Review for Serendipity Theme main-783b47f-2026.05.30.06.53.48

No failures, no warnings. 👍

Comment thread repository/s.json Outdated
Address review: use 'color scheme' terminology and manage package
descriptions on the GitHub repos instead of in the channel entry.

Co-authored-by: Cursor <cursoragent@cursor.com>
@michael-andreuzza

Copy link
Copy Markdown
Contributor Author

Thanks @braver — both remaining points addressed:

Terminology — renamed the channel entries to Sequoia Color Scheme and Serendipity Color Scheme, and updated both READMEs to use "color scheme" consistently (the "Available themes" headings are now "Available color schemes"). The only remaining "Theme" strings are the GitHub org/brand names and the studio name, not the Sublime UI sense.

Descriptions — dropped the inline description from both entries so they're now managed on the GitHub repos instead, where I can update them anytime:

  • Serendipity-Theme/sublime-text → "Serendipity color schemes for Sublime Text — Midnight, Morning, and Sunset."
  • Sequoia-Theme/sublime-text → "Sequoia color schemes for Sublime Text — Moonlight, Monochrome, and Retro (dark and light)."

The s.json diff is now just the two entries (name + details + labels), still in alphabetical order between SequentialBuilder and SerializedDataConverter.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds Sequoia Color Scheme and Serendipity Color Scheme.

Review for Sequoia Color Scheme main-6d5472a-2026.06.01.16.19.20

No failures, no warnings. 👍

Review for Serendipity Color Scheme main-92816a6-2026.06.01.16.19.18

No failures, no warnings. 👍

@braver braver merged commit c8bb622 into sublimehq:master Jun 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants