feat: add dynamic parameter expression #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamachor
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
jcamachor
changed the title
vbarua
reviewed
Jan 29, 2025
EpsilonPrime
previously approved these changes
Jan 30, 2025
jacques-n
reviewed
Feb 1, 2025
jacques-n
reviewed
Feb 5, 2025
jacques-n
reviewed
Feb 5, 2025
jacques-n
approved these changes
Feb 6, 2025
|
@vbarua @EpsilonPrime @westonpace thoughts? |
|
@vbarua , @EpsilonPrime , @westonpace , I'd appreciate your thoughts! Thanks |
vbarua
approved these changes
Feb 13, 2025
EpsilonPrime
approved these changes
Feb 14, 2025
|
Thanks, @jacques-n , @EpsilonPrime , @vbarua ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: This PR adds a dynamic parameter expression to Substrait.
A dynamic parameter expression represents a placeholder within an expression whose value is determined at runtime.
This is particularly useful for parameterized queries where certain values are not known until execution.
Additionally, using dynamic parameters can enable other use cases, such as sharing execution plans without embedding sensitive information.