Skip to content
This repository was archived by the owner on Sep 29, 2022. It is now read-only.

Escape suggestion ids#88

Open
alaninnovates wants to merge 2 commits intosuggestionsbot:mainfrom
alaninnovates:escape-suggestion-ids
Open

Escape suggestion ids#88
alaninnovates wants to merge 2 commits intosuggestionsbot:mainfrom
alaninnovates:escape-suggestion-ids

Conversation

@alaninnovates
Copy link
Copy Markdown
Contributor

@alaninnovates alaninnovates commented Mar 20, 2022

Remove all non alphanumeric characters from commands that take suggestion id as an argument.

Closes #83

Copy link
Copy Markdown
Member

@acollierr17 acollierr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just want you to take a look at the JSDOC comment for the escapeSuggestionId function.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For commands that pass in the suggestion ID, escape non-letter/number characters

2 participants