-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atrium-streams + atrium-streams-client implementation #228
base: main
Are you sure you want to change the base?
Conversation
Obs.: Refer to #223 for information on name choices, as well as why this Draft was re-created. |
9e64589
to
02ef85f
Compare
Force-pushed to re-sync with @sugyan, it seems
Is this expected behaviour? |
I'm not sure since I can't see that event from your link, but it may indeed just be reported and not fail. I didn't really think much about what should happen at first when I installed it. Now I think... it doesn't have to follow strictly and Not Fail is the expected behavior. |
To remove |
This Pull Request adds two new crates:
EventStreamClient
,Handlers
andSubscription
defined in atrium-streams for interacting with the variety of subscriptions in ATProto.TODO:
Firehose
implementation + add configurations to manually enable payload types to avoid unnecessary computations;com.atproto.label.subscribeLabels
+ tests;std::mem::transmute
is not recommended. It works wonderfully for now, but eventually it might not anymore. Think of a way to replace the outdated rs_car crate somehow (if possible).