Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add channel to sign_in and sign_up options #522

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Add missing feature

What is the current behavior?

When using phone auth you can only use sms as a channel

What is the new behavior?

When using phone auth you can now use sms or whatsapp as a channel

Additional context

Add any other context or screenshots.

Copy link
Contributor

sourcery-ai bot commented Jun 17, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please test before merging

@silentworks silentworks force-pushed the silentworks/add-channel-to-sign-up branch from d736149 to 1df49ef Compare June 20, 2024 10:14
@silentworks silentworks merged commit 498640d into main Jun 20, 2024
7 checks passed
@silentworks silentworks deleted the silentworks/add-channel-to-sign-up branch June 20, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants