Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add anonymous login #528

Merged
merged 3 commits into from
Jun 20, 2024
Merged

add anonymous login #528

merged 3 commits into from
Jun 20, 2024

Conversation

houfu
Copy link
Contributor

@houfu houfu commented Jun 18, 2024

What kind of change does this PR introduce?

Fixes #504.
Follows https://github.com/supabase/auth-js/blob/f131300d753634fcf3fbc93dc7a762031f096749/src/GoTrueClient.ts#L370-401
With new types as well

Feedback welcomed.

Copy link
Contributor

sourcery-ai bot commented Jun 18, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@silentworks
Copy link
Contributor

I knew I should have checked PRs before spending my day doing one. I just worked on this yesterday to now see your PR. I will get this reviewed and merged in soon.

@silentworks silentworks changed the title <feat>: Add Anonymous login add anonymous login Jun 20, 2024
@houfu
Copy link
Contributor Author

houfu commented Jun 20, 2024

Sorry about that 🙏

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 22 lines in your changes missing coverage. Please review.

Project coverage is 44.10%. Comparing base (4a18e21) to head (ad2179b).
Report is 10 commits behind head on main.

Files Patch % Lines
supabase_auth/_async/gotrue_client.py 8.33% 11 Missing ⚠️
supabase_auth/_sync/gotrue_client.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   44.38%   44.10%   -0.29%     
==========================================
  Files          23       23              
  Lines        2032     2061      +29     
==========================================
+ Hits          902      909       +7     
- Misses       1130     1152      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks
Copy link
Contributor

I'm going to roll my changes into yours as I can see you've made changes to the sync client but not the async one

Sorry about that 🙏

No, actually thank you for this. It's good to see more first time contributors contributing to this project. I really appreciate this PR.

@silentworks silentworks merged commit 2406d7d into supabase:main Jun 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add anonymous sign-in support
2 participants