-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add anonymous login #528
add anonymous login #528
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
I knew I should have checked PRs before spending my day doing one. I just worked on this yesterday to now see your PR. I will get this reviewed and merged in soon. |
Sorry about that 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 44.38% 44.10% -0.29%
==========================================
Files 23 23
Lines 2032 2061 +29
==========================================
+ Hits 902 909 +7
- Misses 1130 1152 +22 ☔ View full report in Codecov by Sentry. |
I'm going to roll my changes into yours as I can see you've made changes to the sync client but not the async one
No, actually thank you for this. It's good to see more first time contributors contributing to this project. I really appreciate this PR. |
What kind of change does this PR introduce?
Fixes #504.
Follows https://github.com/supabase/auth-js/blob/f131300d753634fcf3fbc93dc7a762031f096749/src/GoTrueClient.ts#L370-401
With new types as well
Feedback welcomed.