Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update property name for should_create_user #531

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Currently the should_create_user property is incorrectly named inside the sign_in_with_otp method

What is the new behavior?

The should_create_user property is correctly named inside the sign_in_with_otp method

Additional context

Add any other context or screenshots.

Copy link
Contributor

sourcery-ai bot commented Jun 23, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@silentworks silentworks merged commit 388fcba into main Jun 23, 2024
7 checks passed
@silentworks silentworks deleted the silentworks/fix-sign-in-with-otp branch June 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant