feat: always consume JSON to prevent resource leaks #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansueli
changed the title
|
Do we have evidence that there were leaks and that this prevents the leaks? I would've expected the response to be GC'd once there's no more reference to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We get resource leaks because in the
_handleRequestfunction, a fetch request is made and its response is thrown if it's not ok.What is the current behavior?
If the noResolveJson option is not set, it returns the JSON body of the response (return result.json()). But in case an error occurs (the response is not ok) or the noResolveJson option is set, the function just throws or returns the response without consuming its body.
What is the new behavior?
It will always consume the response to prevent leaks.
Additional context
Add any other context or screenshots.