feat: integrate tus upload as default upload mechanism #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenos
force-pushed
the
feat/tus-as-peer-depependy
branch
from
378e60d to
4f45a49
Compare
fenos
force-pushed
the
feat/tus-as-peer-depependy
branch
from
4f45a49 to
d928133
Compare
|
Any updates on this request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Tu's uploads are not part of the SDK - developers need to manually setup the tus-js-client to upload with TUS which can be error-prone.
What is the new behavior?
This PR aims to switch the upload mechanism defaulting to TUS when the
tus-js-clientis installed by the project.If it is not installed it will fall back to the traditional standard-upload.
However, if a user has the tus-js-client installed and still wants to use the standard upload mechanism they can simply pass
forceStandardUpload: truein the upload method.Typescript definitions will automagically work as expected in either case when tus-js-client is installed or not.
Additional context
Add any other context or screenshots.
tus-js-clientbecomes an optional peer-dependency for this project to don't increase the bundle size of supabase-js by default