feat: add jwks support #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
commented
Jan 2, 2024
hf
commented
Jan 2, 2024
hf
force-pushed
the
hf/add-jwks-support
branch
9 times, most recently
from
4d11f54 to
c77fe93
Compare
hf
commented
Jan 8, 2024
hf
force-pushed
the
hf/add-jwks-support
branch
2 times, most recently
from
78a6aa7 to
f4895a6
Compare
|
You will need to add a migration under |
Oh yeah, forgot about that! |
hf
force-pushed
the
hf/add-jwks-support
branch
7 times, most recently
from
fe3c5a9 to
565f617
Compare
|
@fenos Can you check why the tests are failing -- I can't seem to figure out what the error is. |
hf
force-pushed
the
hf/add-jwks-support
branch
from
565f617 to
b7d73a8
Compare
fenos
approved these changes
Feb 9, 2024
|
🎉 This PR is included in version 0.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JWKS support, similar to what PostgREST supports.
Why is this necessary?
This opens up avenues where foreign JWTs like those issued by Firebase Auth, Cognito, Clerk, Auth0 can be used directly with Storage, bypassing Supabase Auth or other symmetric use cases.
It also helps with secret rotation.
How it works?
Set the
JWT_JWKSenv var to a JWKS value. In a multi-tenant setup thejwt_jwkscolumn should encode the JWKS as a string, which is then parsed.Security Information
This only affects storage calls that are made "in the name of the user." Signed URLs still continue to use the secret and ignore the existence of the JWKS.
JWK support is built-in to Node.js, so no third-party libraries are used.