Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional file size limit on standard upload #408

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jan 3, 2024

What kind of change does this PR introduce?

Feature

What is the current behavior?

Currently the max file size value is shared between TUS uploads and Standard upload

What is the new behavior?

This PR introduces an optional FILE_SIZE_LIMIT_STANDARD_UPLOAD to limit the file size only for Standard uploads

@fenos fenos force-pushed the feat/standard-upload-limits branch from b3a566f to 822cb32 Compare January 3, 2024 09:18
@coveralls
Copy link

coveralls commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7395480774

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.794%

Totals Coverage Status
Change from base Build 7383976604: -0.02%
Covered Lines: 7601
Relevant Lines: 8893

💛 - Coveralls

@fenos fenos merged commit 01c8a7e into master Jan 3, 2024
1 check passed
@fenos fenos deleted the feat/standard-upload-limits branch January 3, 2024 15:01
Copy link

github-actions bot commented Jan 3, 2024

🎉 This PR is included in version 0.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants