[SDESK-7925] Fix broken build because in superdesk repo#5196
Open
eos87 wants to merge 8 commits into
Open
Conversation
eos87
changed the title
eos87
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves TypeScript type-checking out of the webpack dev-server build and into a dedicated npm run typecheck step that runs in CI, unblocking builds that were failing after upstream extension build changes.
Changes:
- Remove
ForkTsCheckerWebpackPlugin-based type-checking fromwebpack.config.js. - Add
tasks/typecheck.jsand wire it intonpm test; adjustlintto stop runningtscdirectly. - Fix surfaced TypeScript/style issues in a few in-tree extensions (e.g., date-fns import style and CSS logical properties).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.js | Removes webpack-time type-checking configuration. |
| tasks/typecheck.js | Adds a CI-run typecheck script covering core + in-tree extensions. |
| scripts/extensions/videoEditor/src/VideoTimeline/VideoTimeline.tsx | Switches inline positioning styles to logical properties (insetInlineStart). |
| scripts/extensions/videoEditor/src/VideoTimeline/BarIcon.tsx | Switches inline positioning style to logical property (insetBlockStart). |
| scripts/extensions/datetimeField/src/editor.tsx | Consolidates date-fns imports to named exports from date-fns. |
| package.json | Adds typecheck step into test and removes tsc from lint. |
| Gruntfile.js | Converts some grunt task callbacks to arrow functions (no functional change intended). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+57
| const {status} = spawnSync( | ||
| process.execPath, | ||
| [TSC, '--project', tsconfig, '--noEmit', '--pretty'], | ||
| {cwd: ROOT, stdio: 'inherit'} | ||
| ); | ||
|
|
||
| return status === 0; | ||
| } |
petrjasek
approved these changes
May 29, 2026
The "Install Playwright Browsers" step (npx playwright install --with-deps) was hanging for hours on some shards. The --with-deps part runs apt-get, and on ubuntu-latest (now 24.04) needrestart throws an interactive prompt that blocks forever with no TTY. Changes: - Set DEBIAN_FRONTEND=noninteractive and NEEDRESTART_MODE=a so the apt step cannot block on a prompt. - Add timeout-minutes: 15 so a stuck install fails fast instead of burning the full job budget. - Install chromium only (the sole enabled project in playwright.config.ts) instead of all three browsers. - Cache ~/.cache/ms-playwright keyed on the @playwright/test version, so browser binaries are downloaded only on a cache miss. On a hit we still run install-deps (OS libs are not cached) but skip the download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To fix the broken build because of the changes on #5177
What has changed
typecheck(tasks/typecheck.js, included innpmtest and thereforeCI) type-checks core plus every in-tree extension, each against its own tsconfig.Belongs to: SDESK-7925