Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#49): exposing suggestion_group in config settings #51

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AlejandroSuero
Copy link
Contributor

With this changes suggestion_group will be exposed to the config under config.color like:

require("supermaven-nvim").setup({
  color = {
    suggestion_group = "Comment",
  },
})

Allowing users to change it in an easier way.


suggestion_group-changes-demo.mp4

Closes #49.

@AlejandroSuero
Copy link
Contributor Author

AlejandroSuero commented Jun 7, 2024

@sm-victorw @super-jacob When discussing the behaviour on #49 about how SupermavenSuggestion highlight group is set. I tested out using lazy.nvim changing it from lazy = false to event = "VeryLazy" and here are the results:

SupermavenSuggestion-not-loading-on-events.mp4

Should I change this behaviour to create the group SupermavenSuggestion when loading the plugin in this PR, or create another PR with those changes?

EDIT:

Apparently @arnevm123 has created one PR solving this in #53.

@AlejandroSuero
Copy link
Contributor Author

@sm-victorw @super-jacob the changes will be the following:

Delete setting SupermavenSuggestion group in document_listener.lua on VimEnter and left only on ColorSchem event.

And set SupermavenSuggestion group in init.lua in M.setup(args) function without creating an autocmd on events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Customize highlight group
1 participant