Skip to content

Commit

Permalink
rename MappingsPlugin -> QuiltMappingsPlugin and its id mappings-logi…
Browse files Browse the repository at this point in the history
…c -> quilt-mappings

rename MappingsExtension -> QuiltMappingsExtension and its name mappings -> quiltMappings
move enimga_profile.json and simple_type_field_names.json5 to enigma/
rename some things in MappingsExtension
refine MappingsV2JarTask's properties, extract some magic constants, and move some configuration to a configureEach in QuiltMappingsPlugin
  • Loading branch information
supersaiyansubtlety committed Oct 7, 2024
1 parent ce95c5a commit 8f84a8f
Show file tree
Hide file tree
Showing 16 changed files with 167 additions and 113 deletions.
34 changes: 14 additions & 20 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import quilt.internal.tasks.build.MappingsV2JarTask

buildscript {
repositories {
maven {
Expand Down Expand Up @@ -29,13 +31,13 @@ plugins {
id 'java' // for constants, packages, javadoc
id 'maven-publish'
id 'org.cadixdev.licenser' version '0.6.1'
id "mappings-logic"
id "quilt-mappings"
}

mappings {
enigmaProfile = file('enigma_profile.json')
quiltMappings {
enigmaProfileConfig = file('enigma/enigma_profile.json')

unpick = file('unpick/unpick.json')
unpickMeta = file('unpick/unpick.json')
}

combineUnpickDefinitions {
Expand Down Expand Up @@ -118,8 +120,8 @@ import quilt.internal.util.MappingsJavadocProvider
// TODO consider moving cleanable things to build/ so this isn't necessary,
// or put them in .gradle/cleanable/ and only add that here (or MappingsPlugin)
clean.doFirst {
delete mappings.fileConstants.tempDir, mappings.fileConstants.cacheFilesMinecraft
// , mappings.fileConstants.generatedUnpickDefinitions
delete quiltMappings.fileConstants.tempDir, quiltMappings.fileConstants.cacheFilesMinecraft
// , quiltMappings.fileConstants.generatedUnpickDefinitions
}

tasks.build.dependsOn "compressTiny", "tinyJar", "v2UnmergedMappingsJar", "v2MergedMappingsJar"
Expand Down Expand Up @@ -161,31 +163,23 @@ task mappingsUnpicked(type: EnigmaMappingsTask, dependsOn: unpickHashedJar) {
}

task mappings(type: EnigmaMappingsTask, dependsOn: "mapPerVersionMappingsJar") {
jarToMap.set mappings.fileConstants.perVersionMappingsJar
jarToMap.set quiltMappings.fileConstants.perVersionMappingsJar
}

task mappingsUnpickedServer(type: EnigmaMappingsServerTask, dependsOn: unpickHashedJar) {
jarToMap.set unpickHashedJar.outputFile.get()
}

task mappingsServer(type: EnigmaMappingsServerTask, dependsOn: "mapPerVersionMappingsJar") {
jarToMap.set project.extensions.mappings.fileConstants.perVersionMappingsJar
jarToMap.set project.extensions.quiltMappings.fileConstants.perVersionMappingsJar
}

// Only build jars for package infos if we need to actually expose stuff like annotation in the future.

build.dependsOn constantsJar, generatePackageInfoMappings

task buildIntermediary {
dependsOn intermediaryV2MappingsJar, intermediaryV2MergedMappingsJar

onlyIf {
return checkIntermediaryMappings.isPresent()
}
}

task eraseBytecode(type: TransformJarClassesTask, dependsOn: mapNamedJar) {
jarFile = mappings.fileConstants.namedJar
jarFile = quiltMappings.fileConstants.namedJar
output = file(".gradle/temp/erased-classes/")

visitor(DraftsmanAdapterClassVisitor::new)
Expand Down Expand Up @@ -219,7 +213,7 @@ task genFakeSource(type: DecompileTask, dependsOn: [mergeTinyV2, eraseBytecode])
input = eraseBytecode.output.asFile.get()
output = fakeSourceDir
decompiler = Decompilers.VINEFLOWER
libraries = files(mappings.fileConstants.libraries)
libraries = files(quiltMappings.fileConstants.libraries)
decompilerOptions = [
"rsy": "1", // remove synthetics
"dgs": "1", // decompile generic signatures
Expand All @@ -243,7 +237,7 @@ task genFakeSource(type: DecompileTask, dependsOn: [mergeTinyV2, eraseBytecode])
}

task decompileVineflower(type: DecompileTask, dependsOn: [mapNamedJar]) {
input.set mappings.fileConstants.namedJar
input.set quiltMappings.fileConstants.namedJar
output.set file("namedSrc")
decompiler = Decompilers.VINEFLOWER
libraries = files(configurations.decompileClasspath)
Expand Down Expand Up @@ -350,7 +344,7 @@ generatePackageInfoMappings {
mappingLint {
dependsOn mapPerVersionMappingsJar
mappingDirectory = file("mappings")
jarFile = mappings.fileConstants.perVersionMappingsJar
jarFile = quiltMappings.fileConstants.perVersionMappingsJar
}

check.dependsOn mappingLint
Expand Down
6 changes: 3 additions & 3 deletions buildSrc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ test {

gradlePlugin {
plugins {
mappingsLogic {
id = 'mappings-logic'
implementationClass = 'quilt.internal.MappingsPlugin'
quiltMappings {
id = 'quilt-mappings'
implementationClass = 'quilt.internal.QuiltMappingsPlugin'
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import org.gradle.api.GradleException;
import org.gradle.api.Project;
import org.gradle.api.file.DirectoryProperty;
import org.gradle.api.file.RegularFile;
import org.gradle.api.file.RegularFileProperty;
import org.gradle.api.provider.Provider;
Expand All @@ -11,28 +10,30 @@
import java.io.File;
import java.io.IOException;

public abstract class MappingsExtension {
public abstract class QuiltMappingsExtension {
public static final String EXTENSION_NAME = "quiltMappings";

// TODO see if this can use a BuildService
/**
* {@link MappingsPlugin} configures all
* {@link QuiltMappingsPlugin} configures all
* {@link quilt.internal.tasks.EnigmaProfileConsumingTask EnigmaProfileConsumingTask}s to use this profile.
*/
public final Provider<EnigmaProfile> enigmaProfile;

public abstract RegularFileProperty getUnpick();
public abstract RegularFileProperty getUnpickMeta();

private final FileConstants fileConstants;

public static MappingsExtension get(Project project) {
return project.getExtensions().getByType(MappingsExtension.class);
public static QuiltMappingsExtension get(Project project) {
return project.getExtensions().getByType(QuiltMappingsExtension.class);
}

protected abstract RegularFileProperty getEnigmaProfileFile();
protected abstract RegularFileProperty getEnigmaProfileConfigImpl();

public MappingsExtension(Project project) {
public QuiltMappingsExtension(Project project) {
this.fileConstants = new FileConstants(project);

this.enigmaProfile = this.getEnigmaProfileFile()
this.enigmaProfile = this.getEnigmaProfileConfigImpl()
.map(RegularFile::getAsFile)
.map(File::toPath)
.map(profilePath -> {
Expand All @@ -48,15 +49,16 @@ public FileConstants getFileConstants() {
return this.fileConstants;
}

public void setEnigmaProfile(File file) {
this.getEnigmaProfileFile().set(file);
// TODO is there a cleaner way to only expose setters?
public void setEnigmaProfileConfig(File file) {
this.getEnigmaProfileConfigImpl().set(file);
}

public void setEnigmaProfile(RegularFile file) {
this.getEnigmaProfileFile().set(file);
public void setEnigmaProfileConfig(RegularFile file) {
this.getEnigmaProfileConfigImpl().set(file);
}

public void setEnigmaProfile(Provider<? extends RegularFile> fileProvider) {
this.getEnigmaProfileFile().set(fileProvider);
public void setEnigmaProfileConfig(Provider<? extends RegularFile> fileProvider) {
this.getEnigmaProfileConfigImpl().set(fileProvider);
}
}
Loading

1 comment on commit 8f84a8f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With commit 8f84a8f, 11 file(s) were updated with 24 line(s) added and 24 removed compared to the latest Quilt Mappings version.

View the diff here:
diff -bur namedTargetSrc/net/minecraft/client/gui/ParentElement.java namedSrc/net/minecraft/client/gui/ParentElement.java
--- namedTargetSrc/net/minecraft/client/gui/ParentElement.java	2024-10-07 05:54:35.576829992 +0000
+++ namedSrc/net/minecraft/client/gui/ParentElement.java	2024-10-07 05:53:28.728963382 +0000
@@ -153,7 +153,7 @@
     * Mapping not found
     */
    @Override
-   default void setFocused(boolean bl) {
+   default void setFocused(boolean focused) {
    }
 
    /**
diff -bur namedTargetSrc/net/minecraft/client/gui/screen/realms/RealmsMainScreen.java namedSrc/net/minecraft/client/gui/screen/realms/RealmsMainScreen.java
--- namedTargetSrc/net/minecraft/client/gui/screen/realms/RealmsMainScreen.java	2024-10-07 05:54:35.688831451 +0000
+++ namedSrc/net/minecraft/client/gui/screen/realms/RealmsMainScreen.java	2024-10-07 05:53:28.859965055 +0000
@@ -1493,9 +1493,9 @@
        * Mapping not found
        */
       @Override
-      public void setFocused(boolean bl) {
-         super.setFocused(bl);
-         this.button.setFocused(bl);
+      public void setFocused(boolean focused) {
+         super.setFocused(focused);
+         this.button.setFocused(focused);
       }
 
       /**
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/ClickableWidget.java namedSrc/net/minecraft/client/gui/widget/ClickableWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/ClickableWidget.java	2024-10-07 05:54:35.706831685 +0000
+++ namedSrc/net/minecraft/client/gui/widget/ClickableWidget.java	2024-10-07 05:53:28.887965413 +0000
@@ -447,8 +447,8 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
-      this.focused = bl;
+   public void setFocused(boolean focused) {
+      this.focused = focused;
    }
 
    /**
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/DraggingWidget.java namedSrc/net/minecraft/client/gui/widget/DraggingWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/DraggingWidget.java	2024-10-07 05:54:35.582830070 +0000
+++ namedSrc/net/minecraft/client/gui/widget/DraggingWidget.java	2024-10-07 05:53:28.735963471 +0000
@@ -121,7 +121,7 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
-      ParentElement.super.setFocused(bl);
+   public void setFocused(boolean focused) {
+      ParentElement.super.setFocused(focused);
    }
 }
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/EditBoxWidget.java namedSrc/net/minecraft/client/gui/widget/EditBoxWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/EditBoxWidget.java	2024-10-07 05:54:35.674831268 +0000
+++ namedSrc/net/minecraft/client/gui/widget/EditBoxWidget.java	2024-10-07 05:53:28.837964774 +0000
@@ -342,9 +342,9 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
-      super.setFocused(bl);
-      if (bl) {
+   public void setFocused(boolean focused) {
+      super.setFocused(focused);
+      if (focused) {
          this.focusTime = Util.getMeasuringTimeMs();
       }
    }
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/HeaderBar.java namedSrc/net/minecraft/client/gui/widget/HeaderBar.java
--- namedTargetSrc/net/minecraft/client/gui/widget/HeaderBar.java	2024-10-07 05:54:35.742832154 +0000
+++ namedSrc/net/minecraft/client/gui/widget/HeaderBar.java	2024-10-07 05:53:28.926965911 +0000
@@ -122,10 +122,10 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
-      super.setFocused(bl);
+   public void setFocused(boolean focused) {
+      super.setFocused(focused);
       if (this.getFocused() != null) {
-         this.getFocused().setFocused(bl);
+         this.getFocused().setFocused(focused);
       }
    }
 
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/list/EntryListWidget.java namedSrc/net/minecraft/client/gui/widget/list/EntryListWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/list/EntryListWidget.java	2024-10-07 05:54:35.486828820 +0000
+++ namedSrc/net/minecraft/client/gui/widget/list/EntryListWidget.java	2024-10-07 05:53:28.628962105 +0000
@@ -908,7 +908,7 @@
        * @mapping {@literal named setFocused Lnet/minecraft/client/gui/widget/list/EntryListWidget$Entry;setFocused(Z)V}
        */
       @Override
-      public void setFocused(boolean bl) {
+      public void setFocused(boolean focused) {
       }
 
       /**
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/recipe_book/RecipeAlternativesWidget.java namedSrc/net/minecraft/client/gui/widget/recipe_book/RecipeAlternativesWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/recipe_book/RecipeAlternativesWidget.java	2024-10-07 05:54:35.583830083 +0000
+++ namedSrc/net/minecraft/client/gui/widget/recipe_book/RecipeAlternativesWidget.java	2024-10-07 05:53:28.736963484 +0000
@@ -248,7 +248,7 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
+   public void setFocused(boolean focused) {
    }
 
    /**
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/recipe_book/RecipeBookWidget.java namedSrc/net/minecraft/client/gui/widget/recipe_book/RecipeBookWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/recipe_book/RecipeBookWidget.java	2024-10-07 05:54:35.711831750 +0000
+++ namedSrc/net/minecraft/client/gui/widget/recipe_book/RecipeBookWidget.java	2024-10-07 05:53:28.892965477 +0000
@@ -729,7 +729,7 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
+   public void setFocused(boolean focused) {
    }
 
    /**
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/SliderWidget.java namedSrc/net/minecraft/client/gui/widget/SliderWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/SliderWidget.java	2024-10-07 05:54:35.475828677 +0000
+++ namedSrc/net/minecraft/client/gui/widget/SliderWidget.java	2024-10-07 05:53:28.615961938 +0000
@@ -151,9 +151,9 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
-      super.setFocused(bl);
-      if (!bl) {
+   public void setFocused(boolean focused) {
+      super.setFocused(focused);
+      if (!focused) {
          this.mutable = false;
       } else {
          InputType lv = MinecraftClient.getInstance().getLastInputType();
diff -bur namedTargetSrc/net/minecraft/client/gui/widget/TextFieldWidget.java namedSrc/net/minecraft/client/gui/widget/TextFieldWidget.java
--- namedTargetSrc/net/minecraft/client/gui/widget/TextFieldWidget.java	2024-10-07 05:54:35.509829119 +0000
+++ namedSrc/net/minecraft/client/gui/widget/TextFieldWidget.java	2024-10-07 05:53:28.652962411 +0000
@@ -736,10 +736,10 @@
     * Mapping not found
     */
    @Override
-   public void setFocused(boolean bl) {
-      if (this.focusUnlocked || bl) {
-         super.setFocused(bl);
-         if (bl) {
+   public void setFocused(boolean focused) {
+      if (this.focusUnlocked || focused) {
+         super.setFocused(focused);
+         if (focused) {
             this.lastFocusTime = Util.getMeasuringTimeMs();
          }
       }

Please sign in to comment.