add missing .get().getAsFile()s to fix genFakeSource and decompileVin…

…eflower

temporarily make remapTargetMinecraftJar directly depend on unpickTargetJar, shouldn't be necessary once CheckTargetVersionExists and CheckUnpickVersionsMatchTask are converted to BuildService's
add more TODOs to build.gradle

build.gradle

@@ -12,7 +12,7 @@ buildscript {
 			name "Fabric Repository"
 			url 'https://maven.fabricmc.net'
 		}
-		// remove when ASM fix is released
+		// TODO remove when ASM fix is released
 		maven {
 			url = "https://repository.ow2.org/nexus/content/repositories/snapshots/"
 		}
@@ -69,13 +69,14 @@ repositories {
 		name "Quilt Snapshot Repository"
 		url "https://maven.quiltmc.org/repository/snapshot"
 	}
-	// remove when ASM fix is released
+	// TODO remove when ASM fix is released
 	maven {
 		url = "https://repository.ow2.org/nexus/content/repositories/snapshots/"
 	}
 	mavenLocal()
 }
 
+// TODO move at least some of these to MappingsPlugin
 configurations {
 	enigmaRuntime
 	javadocClasspath
@@ -113,18 +114,16 @@ import quilt.internal.tasks.unpick.RemapUnpickDefinitionsTask
 import quilt.internal.tasks.unpick.UnpickJarTask
 import quilt.internal.util.MappingsJavadocProvider
 
+// TODO consider moving cleanable things to build/ so this isn't necessary,
+//  or put them in .gradle/cleanable/ and only add that here (or MappingsPlugin)
 clean.doFirst {
 	delete mappings.fileConstants.tempDir, mappings.fileConstants.cacheFilesMinecraft,
 			mappings.fileConstants.unpickGlDefinitions, mappings.fileConstants.unpickGlStateManagerDefinitions
 }
 
 tasks.build.dependsOn "compressTiny", "tinyJar", "v2UnmergedMappingsJar", "v2MergedMappingsJar"
 
-// task insertAutoGeneratedMappings(dependsOn: [buildMappingsTiny, downloadPerVersionMappings], type: AddProposedMappingsTask) {
-// 	inputJar.set mappings.fileConstants.perVersionMappingsJar
-// 	inputMappings.set buildMappingsTiny.outputMappings
-// }
-
+// TODO move all custom tasks and their configuration to MappingsPlugin
 combineUnpickDefinitions {
 	input = mappings.fileConstants.unpickDefinitions
 	output = new File(mappings.fileConstants.buildDir, 'definitions.unpick')
@@ -286,7 +285,7 @@ task genFakeSource(type: DecompileTask, dependsOn: [mergeTinyV2, eraseBytecode])
 	doFirst {
 		fakeSourceDir.deleteDir()
 
-		def jdProvider = new MappingsJavadocProvider(mergeTinyV2.outputMappings, "named")
+		def jdProvider = new MappingsJavadocProvider(mergeTinyV2.outputMappings.get().getAsFile(), "named")
 		classJavadocProvider(jdProvider)
 		fieldJavadocProvider(jdProvider)
 		methodJavadocProvider(jdProvider)
@@ -305,7 +304,8 @@ task decompileVineflower(type: DecompileTask, dependsOn: [mapNamedJar]) {
 	doFirst {
 		file("namedSrc").deleteDir()
 
-		def javadocProvider = new MappingsJavadocProvider(insertAutoGeneratedMappings.outputMappings, "named")
+		def javadocProvider =
+			new MappingsJavadocProvider(insertAutoGeneratedMappings.outputMappings.get().getAsFile(), "named")
 		classJavadocProvider(javadocProvider)
 		fieldJavadocProvider(javadocProvider)
 		methodJavadocProvider(javadocProvider)

buildSrc/src/main/java/quilt/internal/MappingsPlugin.java

@@ -473,6 +473,10 @@ public void apply(@NotNull Project project) {
         final var remapTargetMinecraftJar = tasks.register(
             RemapTargetMinecraftJarTask.TASK_NAME, RemapTargetMinecraftJarTask.class,
             task -> {
+                // TODO temporary until CheckTargetVersionExists and CheckUnpickVersionsMatchTask
+                //  are converted to BuildService's
+                task.dependsOn(unpickTargetJar);
+
                 task.getInputJar().convention(unpickTargetJar.flatMap(UnpickTargetJarTask::getOutputFile));
 
                 task.getMappingsFile().convention(