Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNG.h #117

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Update RNG.h #117

merged 5 commits into from
Jul 11, 2024

Conversation

Andreya-Autumn
Copy link
Collaborator

Previously added as just a copy of the one in SCXT. I've now:

  • Renamed it to be more consistent with the other files in here
  • Renamed the functions for (what I feel is) better readability
  • Added functions which take max and min input args and return in that range.

@Andreya-Autumn Andreya-Autumn requested a review from baconpaul July 11, 2024 11:47
@Andreya-Autumn
Copy link
Collaborator Author

Hey @baconpaul :)

Would appreciate your eyes on this. I've tested it and confirmed it to work in all the voice effects which need random numbers. Just wanna make sure there's not some subtlety I'm missing before I try to use it in the Shortcircuit codebase proper.

@baconpaul
Copy link
Contributor

As an fyi scripts/fix_code.sh will format fix headers fix include guards etc if that’s useful

@baconpaul
Copy link
Contributor

I’ll miss the short names by the way. Are we sure that at least a few of them like u01 and pm1 are not worth retaining?

@Andreya-Autumn
Copy link
Collaborator Author

As an fyi scripts/fix_code.sh will format fix headers fix include guards etc if that’s useful

Oh that's great thanks!

I’ll miss the short names by the way. Are we sure that at least a few of them like u01 and pm1 are not worth retaining?

I'm not attached really, I'll change it back.

@Andreya-Autumn
Copy link
Collaborator Author

@baconpaul that script won't run for me for some reason, but I fixed the header manually. Anything else that's wrong? I think not right?

And the short names are back, although not the same ones.

If all looks good to you we can merge and I can integrate with Shortcircuit some other time soon.

@Andreya-Autumn Andreya-Autumn merged commit 9917212 into surge-synthesizer:main Jul 11, 2024
3 checks passed
@Andreya-Autumn Andreya-Autumn deleted the rng branch July 11, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants