Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom envs for pods #8

Merged
merged 3 commits into from
Oct 1, 2024
Merged

feat: support custom envs for pods #8

merged 3 commits into from
Oct 1, 2024

Conversation

hegerdes
Copy link
Contributor

@hegerdes hegerdes commented Jun 13, 2024

About

This PR adds support to set custom envs to the deployed pod.

Why

Users may want to set extra envs for proxy setups, logging or other.
A special usecass is to supply credentials, such as the initial password in other ways then setting plain text credentials in the values file.
This allows users to reference existing secrets or configmaps.
This would also fix #1 and similar requirements

@hegerdes
Copy link
Contributor Author

Hi, just wanted to check in. Are PRs welcome? Didn't find a contribution guide.

\cc @sgirones

@sgirones
Copy link
Contributor

Definitely, thanks for the PR!

@sgirones
Copy link
Contributor

You will need to bump the version of the Chart.yaml

@hegerdes
Copy link
Contributor Author

You will need to bump the version of the Chart.yaml

Sure, can do this. What is your versioning schema? Bump to v0.4.0 or 0.3.4?

@sgirones
Copy link
Contributor

let's do 0.3.4 for now. We need to put some more process and structure to this repo and settle on the versioning strategy, so we can align it with the SurrealDB releases.

@hegerdes hegerdes requested a review from sgirones June 21, 2024 08:38
Copy link
Contributor

@sgirones sgirones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hegerdes for the contribution!

@hegerdes
Copy link
Contributor Author

hegerdes commented Aug 5, 2024

We are going to release surrealdb on a new environment soon so I quickly wanted to check in what the state of the PR is. Is there a ETA for the next helm release with this included @sgirones ?

Not having to support our own helm chart for this would make a little easier.

@hegerdes
Copy link
Contributor Author

hegerdes commented Oct 1, 2024

Will there be an answer?
I don't want to be rude but inviting people to contribute, but then ignore them for months does seem a little off. All while publishing a new major version of your product without ever touching the charts or providing an official change-log.

This is extrem strange behavior. I really would like to get this closed.

@sgirones
Copy link
Contributor

sgirones commented Oct 1, 2024

hey @hegerdes, I'm really sorry about this. I got absorbed in internal stuff and missed the notifications on this.

We (I) really appreciate these contributions and we plan to improve how we handle them 🙏

@sgirones sgirones merged commit 889af1d into surrealdb:main Oct 1, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root password should be in a secret
2 participants