-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom envs for pods #8
Conversation
Signed-off-by: Henrik Gerdes <[email protected]>
Hi, just wanted to check in. Are PRs welcome? Didn't find a contribution guide. \cc @sgirones |
Definitely, thanks for the PR! |
You will need to bump the version of the Chart.yaml |
Sure, can do this. What is your versioning schema? Bump to |
let's do |
…ming Signed-off-by: Henrik Gerdes <[email protected]>
Signed-off-by: Henrik Gerdes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @hegerdes for the contribution!
We are going to release surrealdb on a new environment soon so I quickly wanted to check in what the state of the PR is. Is there a ETA for the next helm release with this included @sgirones ? Not having to support our own helm chart for this would make a little easier. |
Will there be an answer? This is extrem strange behavior. I really would like to get this closed. |
hey @hegerdes, I'm really sorry about this. I got absorbed in internal stuff and missed the notifications on this. We (I) really appreciate these contributions and we plan to improve how we handle them 🙏 |
About
This PR adds support to set custom envs to the deployed pod.
Why
Users may want to set extra envs for proxy setups, logging or other.
A special usecass is to supply credentials, such as the initial password in other ways then setting plain text credentials in the values file.
This allows users to reference existing secrets or configmaps.
This would also fix #1 and similar requirements