⚡️ avoid registering HttpClient if not using http(s) protocol (#147)

surrealdb · Nov 28, 2024 · a7a5a30 · a7a5a30
1 parent 8a59619
commit a7a5a30
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs b/SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs
@@ -133,7 +133,11 @@ public static SurrealDbBuilder AddSurreal<T>(
         if (configuration.Endpoint is null)
             throw new ArgumentNullException(nameof(configuration), "The endpoint is required.");
 
-        RegisterHttpClient(services, configuration.Endpoint);
+        bool shouldRegisterHttpClient = new Uri(configuration.Endpoint).Scheme is "http" or "https";
+        if (shouldRegisterHttpClient)
+        {
+            RegisterHttpClient(services, configuration.Endpoint);
+        }
 
         var classClientType = typeof(SurrealDbClient);
         var interfaceClientType = typeof(ISurrealDbClient);
@@ -195,7 +199,7 @@ private static void RegisterSurrealDbClient<T>(
                         return new SurrealDbClient(
                             configuration,
                             serviceProvider,
-                            serviceProvider.GetRequiredService<IHttpClientFactory>(),
+                            serviceProvider.GetService<IHttpClientFactory>(),
                             configureCborOptions,
                             serviceProvider.GetService<ILoggerFactory>()
                         );
@@ -210,7 +214,7 @@ private static void RegisterSurrealDbClient<T>(
                         return new SurrealDbClient(
                             configuration,
                             serviceProvider,
-                            serviceProvider.GetRequiredService<IHttpClientFactory>(),
+                            serviceProvider.GetService<IHttpClientFactory>(),
                             configureCborOptions,
                             serviceProvider.GetService<ILoggerFactory>()
                         );
@@ -225,7 +229,7 @@ private static void RegisterSurrealDbClient<T>(
                         return new SurrealDbClient(
                             configuration,
                             serviceProvider,
-                            serviceProvider.GetRequiredService<IHttpClientFactory>(),
+                            serviceProvider.GetService<IHttpClientFactory>(),
                             configureCborOptions,
                             serviceProvider.GetService<ILoggerFactory>()
                         );