Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 automatically add /rpc suffix for ws protocols #157

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Dec 9, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What does this change do?

Add /rpc suffix to prevent issue when providing an incomplete WS endpoint.

What is your testing strategy?

Unit test

Is this related to any issues?

N/A

Have you read the Contributing Guidelines?

@Odonno Odonno force-pushed the feat/rpc-ws-suffix branch from 583cc10 to 158d700 Compare December 10, 2024 19:47
@kearfy kearfy merged commit 46d8b4b into surrealdb:main Dec 12, 2024
8 checks passed
@Odonno Odonno deleted the feat/rpc-ws-suffix branch December 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants