Skip to content

Address review comments #943

Address review comments

Address review comments #943

GitHub Actions / IntegrationTests_9 Test Reports succeeded Nov 22, 2025 in 1s

96 passed, 2 failed and 8 skipped

Tests failed

Report Passed Failed Skipped Time
IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.xml 15✅ 1❌ 4⚪ 1452s
IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.PushJobDetailsTest.xml 4✅ 403s
IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions.xml 2✅ 275s
IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestStoreMigration.xml 11✅ 365s
IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest.xml 8✅ 3s
IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.helix.TestHelixExternalViewRepository.xml 8✅ 51s
internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.xml 15✅ 1❌ 4⚪ 1452s
internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.PushJobDetailsTest.xml 4✅ 403s
internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions.xml 2✅ 275s
internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestStoreMigration.xml 11✅ 365s
internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest.xml 8✅ 3s
internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.helix.TestHelixExternalViewRepository.xml 8✅ 51s

❌ IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.xml

20 tests were completed in 1452s with 15 passed, 1 failed and 4 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment 15✅ 1❌ 4⚪ 1452s

❌ com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment

✅ testAbortMigrationStoreDeletion
✅ testControllerFailOver
✅ testDeadStoreStatsInitialization
✅ testExternalViewDataChangeDeadLock
✅ testGetFutureVersionsNotBlocked
❌ setUp
	java.lang.AssertionError: expected object to not be null
⚪ testGetLeaderController
⚪ testIdempotentStoreDeletion
⚪ testStoreLifecycleValidateDeleted_WithLeftoverTopics
⚪ testStoreLifecycle_ValidateDeleted
✅ testAbortMigrationStoreDeletion
✅ testControllerFailOver
✅ testDeadStoreStatsInitialization
✅ testExternalViewDataChangeDeadLock
✅ testGetFutureVersionsNotBlocked
✅ testGetLeaderController
✅ testIdempotentStoreDeletion
✅ testStoreLifecycleValidateDeleted_WithLeftoverTopics
✅ testStoreLifecycle_ValidateDeleted
✅ setUp

✅ IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.PushJobDetailsTest.xml

4 tests were completed in 403s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.PushJobDetailsTest 4✅ 403s

✅ com.linkedin.venice.endToEnd.PushJobDetailsTest

✅ testPushJobDetails[0](false, false)
✅ testPushJobDetails[2](true, false)
✅ testPushJobDetails[4](false, true)
✅ testPushJobDetails[6](true, true)

✅ IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions.xml

2 tests were completed in 275s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions 2✅ 275s

✅ com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions

✅ testDeferredVersionSwapWithFailedPushInTargetRegions
✅ testDvcDelayedIngestionWithFailingPushInTargetRegion

✅ IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestStoreMigration.xml

11 tests were completed in 365s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestStoreMigration 11✅ 365s

✅ com.linkedin.venice.endToEnd.TestStoreMigration

✅ testAutoStoreMigration
✅ testStoreMigration
✅ testStoreMigrationAfterFailedAttempt
✅ testStoreMigrationForFastClient
✅ testStoreMigrationStaleKillIngestionMessageDeletion
✅ testStoreMigrationWithDaVinciPushStatusSystemStore
✅ testStoreMigrationWithMetaSystemStore
✅ testStoreMigrationWithNewPushesAndUpdates
✅ testStoreMigrationWithPushJobTrackingVTInParentRegion
✅ testStoreMigrationWithStoreConfigs
✅ testVersionConfigsRemainSameAfterStoreMigration

✅ IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest.xml

8 tests were completed in 3s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest 8✅ 3s

✅ com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest

✅ testBatchGetGenericClient[0](false, SERVER_BASED_METADATA)
✅ testBatchGetGenericClient[2](true, SERVER_BASED_METADATA)
✅ testBatchGetSpecificClient[0](SERVER_BASED_METADATA)
✅ testStreamingBatchGetGenericClient[0](false, SERVER_BASED_METADATA)
✅ testStreamingBatchGetGenericClient[2](true, SERVER_BASED_METADATA)
✅ testStreamingBatchGetLimit
✅ testStreamingBatchGetWithCallbackGenericClient[0](false, SERVER_BASED_METADATA)
✅ testStreamingBatchGetWithCallbackGenericClient[2](true, SERVER_BASED_METADATA)

✅ IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.helix.TestHelixExternalViewRepository.xml

8 tests were completed in 51s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixExternalViewRepository 8✅ 51s

✅ com.linkedin.venice.helix.TestHelixExternalViewRepository

✅ testControllerChanged
✅ testGetInstances
✅ testGetNumberOfPartitions
✅ testGetNumberOfPartitionsWhenResourceDropped
✅ testGetPartitions
✅ testListeners
✅ testNodeChanged
✅ testPartitionMove

❌ internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.xml

20 tests were completed in 1452s with 15 passed, 1 failed and 4 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment 15✅ 1❌ 4⚪ 1452s

❌ com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment

✅ testAbortMigrationStoreDeletion
✅ testControllerFailOver
✅ testDeadStoreStatsInitialization
✅ testExternalViewDataChangeDeadLock
✅ testGetFutureVersionsNotBlocked
❌ setUp
	java.lang.AssertionError: expected object to not be null
⚪ testGetLeaderController
⚪ testIdempotentStoreDeletion
⚪ testStoreLifecycleValidateDeleted_WithLeftoverTopics
⚪ testStoreLifecycle_ValidateDeleted
✅ testAbortMigrationStoreDeletion
✅ testControllerFailOver
✅ testDeadStoreStatsInitialization
✅ testExternalViewDataChangeDeadLock
✅ testGetFutureVersionsNotBlocked
✅ testGetLeaderController
✅ testIdempotentStoreDeletion
✅ testStoreLifecycleValidateDeleted_WithLeftoverTopics
✅ testStoreLifecycle_ValidateDeleted
✅ setUp

✅ internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.PushJobDetailsTest.xml

4 tests were completed in 403s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.PushJobDetailsTest 4✅ 403s

✅ com.linkedin.venice.endToEnd.PushJobDetailsTest

✅ testPushJobDetails[0](false, false)
✅ testPushJobDetails[2](true, false)
✅ testPushJobDetails[4](false, true)
✅ testPushJobDetails[6](true, true)

✅ internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions.xml

2 tests were completed in 275s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions 2✅ 275s

✅ com.linkedin.venice.endToEnd.TestDeferredVersionSwapWithFailingRegions

✅ testDeferredVersionSwapWithFailedPushInTargetRegions
✅ testDvcDelayedIngestionWithFailingPushInTargetRegion

✅ internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.endToEnd.TestStoreMigration.xml

11 tests were completed in 365s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestStoreMigration 11✅ 365s

✅ com.linkedin.venice.endToEnd.TestStoreMigration

✅ testAutoStoreMigration
✅ testStoreMigration
✅ testStoreMigrationAfterFailedAttempt
✅ testStoreMigrationForFastClient
✅ testStoreMigrationStaleKillIngestionMessageDeletion
✅ testStoreMigrationWithDaVinciPushStatusSystemStore
✅ testStoreMigrationWithMetaSystemStore
✅ testStoreMigrationWithNewPushesAndUpdates
✅ testStoreMigrationWithPushJobTrackingVTInParentRegion
✅ testStoreMigrationWithStoreConfigs
✅ testVersionConfigsRemainSameAfterStoreMigration

✅ internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest.xml

8 tests were completed in 3s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest 8✅ 3s

✅ com.linkedin.venice.fastclient.BatchGetAvroStoreClientTest

✅ testBatchGetGenericClient[0](false, SERVER_BASED_METADATA)
✅ testBatchGetGenericClient[2](true, SERVER_BASED_METADATA)
✅ testBatchGetSpecificClient[0](SERVER_BASED_METADATA)
✅ testStreamingBatchGetGenericClient[0](false, SERVER_BASED_METADATA)
✅ testStreamingBatchGetGenericClient[2](true, SERVER_BASED_METADATA)
✅ testStreamingBatchGetLimit
✅ testStreamingBatchGetWithCallbackGenericClient[0](false, SERVER_BASED_METADATA)
✅ testStreamingBatchGetWithCallbackGenericClient[2](true, SERVER_BASED_METADATA)

✅ internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.helix.TestHelixExternalViewRepository.xml

8 tests were completed in 51s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixExternalViewRepository 8✅ 51s

✅ com.linkedin.venice.helix.TestHelixExternalViewRepository

✅ testControllerChanged
✅ testGetInstances
✅ testGetNumberOfPartitions
✅ testGetNumberOfPartitionsWhenResourceDropped
✅ testGetPartitions
✅ testListeners
✅ testNodeChanged
✅ testPartitionMove

Annotations

Check failure on line 101 in internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/integration/utils/IntegrationTestUtils.java

See this annotation in the file changed.

@github-actions github-actions / IntegrationTests_9 Test Reports

com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment ► setUp

Failed test found in:
  IntegrationTests_9-artifacts/internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.xml
  internal/venice-test-common/build/test-results/integrationTests_9/TEST-com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.xml
Error:
  java.lang.AssertionError: expected object to not be null
Raw output
java.lang.AssertionError: expected object to not be null
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.assertNotNull(Assert.java:686)
	at org.testng.Assert.assertNotNull(Assert.java:671)
	at com.linkedin.venice.integration.utils.IntegrationTestUtils.lambda$verifyParticipantMessageStoreSetup$0(IntegrationTestUtils.java:101)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:287)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:272)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:264)
	at com.linkedin.venice.integration.utils.IntegrationTestUtils.verifyParticipantMessageStoreSetup(IntegrationTestUtils.java:99)
	at com.linkedin.venice.controller.AbstractTestVeniceHelixAdmin.setupCluster(AbstractTestVeniceHelixAdmin.java:195)
	at com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.setupCluster(TestVeniceHelixAdminWithIsolatedEnvironment.java:46)
	at com.linkedin.venice.controller.TestVeniceHelixAdminWithIsolatedEnvironment.setUp(TestVeniceHelixAdminWithIsolatedEnvironment.java:51)