Skip to content

Address review comments #943

Address review comments

Address review comments #943

GitHub Actions / IntegrationTests_12 Test Reports succeeded Nov 22, 2025 in 1s

148 passed, 4 failed and 0 skipped

Tests failed

Report Passed Failed Skipped Time
IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.controller.TestHAASController.xml 11✅ 264s
IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTest.xml 11✅ 382s
IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest.xml 2✅ 64s
IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.TestBatchForRocksDB.xml 38✅ 299s
IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml 12✅ 2❌ 323s
internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.controller.TestHAASController.xml 11✅ 264s
internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTest.xml 11✅ 382s
internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest.xml 2✅ 64s
internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.TestBatchForRocksDB.xml 38✅ 299s
internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml 12✅ 2❌ 323s

✅ IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.controller.TestHAASController.xml

11 tests were completed in 264s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.TestHAASController 11✅ 264s

✅ com.linkedin.venice.controller.TestHAASController

✅ testCloudConfig
✅ testClusterResourceEmptyInstanceTag
✅ testClusterResourceInstanceTag
✅ testClusterResourceInstanceTag_updateOnRestart
✅ testConcurrentClusterInitialization
✅ testHelixUnknownInstanceOperation
✅ testRebalancePreferenceAndCapacityKeys
✅ testStartHAASControllerAsStorageClusterLeader
✅ testStartHAASHelixControllerAsControllerClusterLeader
✅ testTransitionToHAASControllerAsControllerClusterLeader
✅ testTransitionToHAASControllerAsStorageClusterLeader

✅ IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTest.xml

11 tests were completed in 382s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientTest 11✅ 382s

✅ com.linkedin.venice.endToEnd.DaVinciClientTest

✅ testConcurrentGetAndStart[0](false)
✅ testConcurrentGetAndStart[2](true)
✅ testIsDavinciHeartbeatReported
✅ testObjectReuse[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testObjectReuse[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testReadCompressedData[0](NO_OP)
✅ testReadCompressedData[2](GZIP)
✅ testReadCompressedData[4](ZSTD_WITH_DICT)
✅ testStatusReportDuringBoostrap[0](BUILT_IN, true)
✅ testStatusReportDuringBoostrap[2](ISOLATED, false)
✅ testStatusReportDuringBoostrap[4](ISOLATED, true)

✅ IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest.xml

2 tests were completed in 64s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest 2✅ 64s

✅ com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest

✅ testHybridStore[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testHybridStore[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})

✅ IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.TestBatchForRocksDB.xml

38 tests were completed in 299s with 38 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestBatchForRocksDB 38✅ 299s

✅ com.linkedin.venice.endToEnd.TestBatchForRocksDB

✅ testBatchFromETL
✅ testBatchFromETLForUnionWithNullSchema
✅ testBatchFromETLForUnionWithoutNullSchema
✅ testBatchFromETLWithNullDefaultValue
✅ testCompressingRecord[0](false)
✅ testCompressingRecord[2](true)
✅ testDataPushWithSchemaWithAWrongDefault
✅ testDuplicateKey
✅ testEarlyDeleteBackupStore
✅ testEmptyPush
✅ testIncrementalPush
✅ testIncrementalPushWithCompression[0](false)
✅ testIncrementalPushWithCompression[2](true)
✅ testIncrementalPushWritesToRealTimeTopicWithPolicy
✅ testKafkaInputAAStore
✅ testKafkaInputBatchJob
✅ testKafkaInputBatchJobSucceedsWhenSourceTopicIsEmpty
✅ testKafkaInputBatchJobWithLargeValues[0](false)
✅ testKafkaInputBatchJobWithLargeValues[2](true)
✅ testKafkaInputBatchJobWithZstdCompression[0](false)
✅ testKafkaInputBatchJobWithZstdCompression[2](true)
✅ testLargeValues
✅ testMetaStoreSchemaValidation
✅ testReducerCountValidation
✅ testRunJobWithSchemaThatContainsUnknownField
✅ testStoreWithNoVersionThrows400
✅ testStoreWithTooLargeValues[0](false)
✅ testStoreWithTooLargeValues[2](true)
✅ testStoreWithTooLargeValuesWithCompression[0](false, NO_OP)
✅ testStoreWithTooLargeValuesWithCompression[2](true, NO_OP)
✅ testStoreWithTooLargeValuesWithCompression[4](false, GZIP)
✅ testStoreWithTooLargeValuesWithCompression[6](true, GZIP)
✅ testStoreWithTooLargeValuesWithCompression[8](false, ZSTD_WITH_DICT)
✅ testStoreWithTooLargeValuesWithCompression[10](true, ZSTD_WITH_DICT)
✅ testZstdCompressingAvroRecordCanFailWhenNoFallbackAvailable
✅ testZstdCompressingAvroRecordWhenFallbackAvailable[0](false)
✅ testZstdCompressingAvroRecordWhenFallbackAvailable[2](true)
✅ testZstdCompressingAvroRecordWhenNoFallbackAvailableWithSleep

❌ IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml

14 tests were completed in 323s with 12 passed, 2 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.server.VeniceServerTest 12✅ 2❌ 323s

❌ com.linkedin.venice.server.VeniceServerTest

✅ testCheckBeforeJoinCluster
✅ testCheckBeforeJointClusterBeforeHelixInitializingCluster
✅ testDropStorePartitionAsynchronously
❌ testDropStorePartitionSynchronously
	java.lang.AssertionError: Storage engine: store_12bcd6f2b71_547ea8dc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@50d107ac]
✅ testMetadataFetchRequest
✅ testStartServerAndShutdownWithPartitionAssignmentVerification
✅ testStartServerWhenEnableAllowlistCheckingFailed
✅ testStartServerWhenEnableAllowlistCheckingSuccessful
✅ testStartServerWithDefaultConfigForTests
✅ testStartServerWithSystemSchemaInitialization
✅ testVeniceServerWithD2[0](false)
✅ testVeniceServerWithD2[1](true)
❌ testDropStorePartitionSynchronously
	java.lang.AssertionError: Storage engine: store_159b09dc873_dd68badc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@7540e2bc]
✅ testDropStorePartitionSynchronously

✅ internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.controller.TestHAASController.xml

11 tests were completed in 264s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.TestHAASController 11✅ 264s

✅ com.linkedin.venice.controller.TestHAASController

✅ testCloudConfig
✅ testClusterResourceEmptyInstanceTag
✅ testClusterResourceInstanceTag
✅ testClusterResourceInstanceTag_updateOnRestart
✅ testConcurrentClusterInitialization
✅ testHelixUnknownInstanceOperation
✅ testRebalancePreferenceAndCapacityKeys
✅ testStartHAASControllerAsStorageClusterLeader
✅ testStartHAASHelixControllerAsControllerClusterLeader
✅ testTransitionToHAASControllerAsControllerClusterLeader
✅ testTransitionToHAASControllerAsStorageClusterLeader

✅ internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTest.xml

11 tests were completed in 382s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientTest 11✅ 382s

✅ com.linkedin.venice.endToEnd.DaVinciClientTest

✅ testConcurrentGetAndStart[0](false)
✅ testConcurrentGetAndStart[2](true)
✅ testIsDavinciHeartbeatReported
✅ testObjectReuse[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testObjectReuse[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testReadCompressedData[0](NO_OP)
✅ testReadCompressedData[2](GZIP)
✅ testReadCompressedData[4](ZSTD_WITH_DICT)
✅ testStatusReportDuringBoostrap[0](BUILT_IN, true)
✅ testStatusReportDuringBoostrap[2](ISOLATED, false)
✅ testStatusReportDuringBoostrap[4](ISOLATED, true)

✅ internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest.xml

2 tests were completed in 64s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest 2✅ 64s

✅ com.linkedin.venice.endToEnd.DaVinciClientTestWithHeartbeatReadyToServeCheckTest

✅ testHybridStore[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testHybridStore[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})

✅ internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.endToEnd.TestBatchForRocksDB.xml

38 tests were completed in 299s with 38 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestBatchForRocksDB 38✅ 299s

✅ com.linkedin.venice.endToEnd.TestBatchForRocksDB

✅ testBatchFromETL
✅ testBatchFromETLForUnionWithNullSchema
✅ testBatchFromETLForUnionWithoutNullSchema
✅ testBatchFromETLWithNullDefaultValue
✅ testCompressingRecord[0](false)
✅ testCompressingRecord[2](true)
✅ testDataPushWithSchemaWithAWrongDefault
✅ testDuplicateKey
✅ testEarlyDeleteBackupStore
✅ testEmptyPush
✅ testIncrementalPush
✅ testIncrementalPushWithCompression[0](false)
✅ testIncrementalPushWithCompression[2](true)
✅ testIncrementalPushWritesToRealTimeTopicWithPolicy
✅ testKafkaInputAAStore
✅ testKafkaInputBatchJob
✅ testKafkaInputBatchJobSucceedsWhenSourceTopicIsEmpty
✅ testKafkaInputBatchJobWithLargeValues[0](false)
✅ testKafkaInputBatchJobWithLargeValues[2](true)
✅ testKafkaInputBatchJobWithZstdCompression[0](false)
✅ testKafkaInputBatchJobWithZstdCompression[2](true)
✅ testLargeValues
✅ testMetaStoreSchemaValidation
✅ testReducerCountValidation
✅ testRunJobWithSchemaThatContainsUnknownField
✅ testStoreWithNoVersionThrows400
✅ testStoreWithTooLargeValues[0](false)
✅ testStoreWithTooLargeValues[2](true)
✅ testStoreWithTooLargeValuesWithCompression[0](false, NO_OP)
✅ testStoreWithTooLargeValuesWithCompression[2](true, NO_OP)
✅ testStoreWithTooLargeValuesWithCompression[4](false, GZIP)
✅ testStoreWithTooLargeValuesWithCompression[6](true, GZIP)
✅ testStoreWithTooLargeValuesWithCompression[8](false, ZSTD_WITH_DICT)
✅ testStoreWithTooLargeValuesWithCompression[10](true, ZSTD_WITH_DICT)
✅ testZstdCompressingAvroRecordCanFailWhenNoFallbackAvailable
✅ testZstdCompressingAvroRecordWhenFallbackAvailable[0](false)
✅ testZstdCompressingAvroRecordWhenFallbackAvailable[2](true)
✅ testZstdCompressingAvroRecordWhenNoFallbackAvailableWithSleep

❌ internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml

14 tests were completed in 323s with 12 passed, 2 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.server.VeniceServerTest 12✅ 2❌ 323s

❌ com.linkedin.venice.server.VeniceServerTest

✅ testCheckBeforeJoinCluster
✅ testCheckBeforeJointClusterBeforeHelixInitializingCluster
✅ testDropStorePartitionAsynchronously
❌ testDropStorePartitionSynchronously
	java.lang.AssertionError: Storage engine: store_12bcd6f2b71_547ea8dc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@50d107ac]
✅ testMetadataFetchRequest
✅ testStartServerAndShutdownWithPartitionAssignmentVerification
✅ testStartServerWhenEnableAllowlistCheckingFailed
✅ testStartServerWhenEnableAllowlistCheckingSuccessful
✅ testStartServerWithDefaultConfigForTests
✅ testStartServerWithSystemSchemaInitialization
✅ testVeniceServerWithD2[0](false)
✅ testVeniceServerWithD2[1](true)
❌ testDropStorePartitionSynchronously
	java.lang.AssertionError: Storage engine: store_159b09dc873_dd68badc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@7540e2bc]
✅ testDropStorePartitionSynchronously

Annotations

Check failure on line 486 in internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/server/VeniceServerTest.java

See this annotation in the file changed.

@github-actions github-actions / IntegrationTests_12 Test Reports

com.linkedin.venice.server.VeniceServerTest ► testDropStorePartitionSynchronously

Failed test found in:
  IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml
  internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml
Error:
  java.lang.AssertionError: Storage engine: store_12bcd6f2b71_547ea8dc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@50d107ac]
Raw output
java.lang.AssertionError: Storage engine: store_12bcd6f2b71_547ea8dc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@50d107ac]
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.failNotSame(Assert.java:772)
	at org.testng.Assert.assertNull(Assert.java:708)
	at com.linkedin.venice.server.VeniceServerTest.lambda$testDropStorePartitionSynchronously$14(VeniceServerTest.java:486)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:287)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:272)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:264)
	at com.linkedin.venice.server.VeniceServerTest.testDropStorePartitionSynchronously(VeniceServerTest.java:484)

Check failure on line 486 in internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/server/VeniceServerTest.java

See this annotation in the file changed.

@github-actions github-actions / IntegrationTests_12 Test Reports

com.linkedin.venice.server.VeniceServerTest ► testDropStorePartitionSynchronously

Failed test found in:
  IntegrationTests_12-artifacts/internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml
  internal/venice-test-common/build/test-results/integrationTests_12/TEST-com.linkedin.venice.server.VeniceServerTest.xml
Error:
  java.lang.AssertionError: Storage engine: store_159b09dc873_dd68badc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@7540e2bc]
Raw output
java.lang.AssertionError: Storage engine: store_159b09dc873_dd68badc_v1 should have been dropped expected [null] but found [com.linkedin.davinci.store.DelegatingStorageEngine@7540e2bc]
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.failNotSame(Assert.java:772)
	at org.testng.Assert.assertNull(Assert.java:708)
	at com.linkedin.venice.server.VeniceServerTest.lambda$testDropStorePartitionSynchronously$14(VeniceServerTest.java:486)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:287)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:272)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:264)
	at com.linkedin.venice.server.VeniceServerTest.testDropStorePartitionSynchronously(VeniceServerTest.java:484)