Address review comments #984
Matrix: Clients / UT & CodeCov
Matrix: Controller / UT & CodeCov
Matrix: Integrations / UT & CodeCov
Matrix: Internal / UT & CodeCov
Matrix: Router / UT & CodeCov
Matrix: Server / UT & CodeCov
Matrix: StaticAnalysis
ValidateGradleWrapper
11s
StaticAnalysisAndUnitTestsFailureAlert
0s
Annotations
16 errors and 19 warnings
|
RetriableAvroGenericStoreClientTest.testGetWithTriggeringLongTailRetryAndRetryWins[4](MULTI_GET_STREAMING, false, false):
clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientTest.java#L714
java.lang.AssertionError: expected [true] but found [false]
|
|
RetriableAvroGenericStoreClientTest.testGetWithTriggeringLongTailRetryAndRetryWins[2](MULTI_GET, false, false):
clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientTest.java#L716
java.lang.AssertionError: expected [true] but found [false]
|
|
RetriableAvroGenericStoreClientTest.testGetWithTriggeringLongTailRetryAndRetryWins[4](MULTI_GET_STREAMING, false, false):
clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientTest.java#L714
java.lang.AssertionError: expected [true] but found [false]
|
|
RetriableAvroGenericStoreClientTest.testGetWithTriggeringLongTailRetryAndRetryWins[2](MULTI_GET, false, false):
clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientTest.java#L716
java.lang.AssertionError: expected [true] but found [false]
|
|
InstanceSizeEstimatorTest.testInstanceMeasurement:
internal/venice-common/src/test/java/com/linkedin/venice/memory/InstanceSizeEstimatorTest.java#L49
java.lang.AssertionError: Class KafkaKey has a memoryAllocatedPerInstance (53.19892) which is too far from the predictedUsage (40); delta: 0.330; maxAllowedDelta: 0.019. No more attempts left.
|
|
InstanceSizeEstimatorTest.testInstanceMeasurement:
internal/venice-common/src/test/java/com/linkedin/venice/memory/InstanceSizeEstimatorTest.java#L49
java.lang.AssertionError: Class KafkaKey has a memoryAllocatedPerInstance (53.19892) which is too far from the predictedUsage (40); delta: 0.330; maxAllowedDelta: 0.019. No more attempts left.
|
|
RetriableAvroGenericStoreClientRetryBudgetTest.testGetWithTriggeringLongTailRetryAndRetryWins[12](MULTI_GET, true, false):
clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientRetryBudgetTest.java#L1
java.lang.AssertionError: expected [true] but found [false]
|
|
RetriableAvroGenericStoreClientRetryBudgetTest.testGetWithTriggeringLongTailRetryAndRetryWins[12](MULTI_GET, true, false):
clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientRetryBudgetTest.java#L1
java.lang.AssertionError: expected [true] but found [false]
|
|
|
|
SITWithSAwarePWiseWithoutBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false):
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
org.mockito.exceptions.verification.TooFewActualInvocations:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
Wanted 2 times:
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
But was 1 time:
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2739)
|
|
|
|
SITWithSAwarePWiseWithoutBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false):
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
org.mockito.exceptions.verification.TooFewActualInvocations:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
Wanted 2 times:
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
But was 1 time:
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2739)
|
|
SITWithPWiseWithoutBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false):
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseWithoutBufferAfterLeaderTest.java#L1
org.mockito.exceptions.verification.TooFewActualInvocations:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
Wanted 2 times:
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
But was 1 time:
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2739)
|
|
SITWithPWiseWithoutBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false):
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseWithoutBufferAfterLeaderTest.java#L1
org.mockito.exceptions.verification.TooFewActualInvocations:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
Wanted 2 times:
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
But was 1 time:
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2739)
|
|
SITWithPWiseAndBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false):
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
Wanted but not invoked:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
However, there were exactly 15 interactions with this mock:
hostLevelIngestionStats.recordProcessConsumerActionLatency(
3.0d
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:2113)
hostLevelIngestionStats.recordCheckLongRunningTasksLatency(
0.063018d
);
-> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:781)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1726)
hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency(
0.078886d,
1763850614560L
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1417)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1422)
hostLevelIngestionStats.recordTotalRecordsConsumed();
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2731)
hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency(
0.057567999999999994d,
1763850614563L
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1417)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1422)
hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency(
0.03723d,
1763850614575L
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1417)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1422)
hostLevelIngestionStats.recordTotalRecordsConsumed();
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2731)
hostLevelIngestionStats.recordTotalRecordsConsumed();
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2731)
hostLevelIngestionStats.recordProcessConsumerActionLatency(
0.0d
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:2113)
hostLevelIngestionStats.recordCheckLongRunningTasksLatency(
0.045074d
);
-> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:781)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1726)
|
|
SITWithPWiseAndBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false):
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
Wanted but not invoked:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
However, there were exactly 15 interactions with this mock:
hostLevelIngestionStats.recordProcessConsumerActionLatency(
3.0d
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:2113)
hostLevelIngestionStats.recordCheckLongRunningTasksLatency(
0.063018d
);
-> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:781)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1726)
hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency(
0.078886d,
1763850614560L
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1417)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1422)
hostLevelIngestionStats.recordTotalRecordsConsumed();
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2731)
hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency(
0.057567999999999994d,
1763850614563L
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1417)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1422)
hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency(
0.03723d,
1763850614575L
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1417)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1422)
hostLevelIngestionStats.recordTotalRecordsConsumed();
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2731)
hostLevelIngestionStats.recordTotalRecordsConsumed();
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2731)
hostLevelIngestionStats.recordProcessConsumerActionLatency(
0.0d
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:2113)
hostLevelIngestionStats.recordCheckLongRunningTasksLatency(
0.045074d
);
-> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:781)
hostLevelIngestionStats.recordStorageQuotaUsed(
NaNd
);
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1726)
|
|
Integrations / UT & CodeCov (11)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
StaticAnalysis (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Clients / UT & CodeCov (11)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Integrations / UT & CodeCov (8)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Integrations / UT & CodeCov (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Internal / UT & CodeCov (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Controller / UT & CodeCov (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Clients / UT & CodeCov (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Controller / UT & CodeCov (11)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Internal / UT & CodeCov (8)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Router / UT & CodeCov (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Clients / UT & CodeCov (8)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Internal / UT & CodeCov (11)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Router / UT & CodeCov (8)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Router / UT & CodeCov (11)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Controller / UT & CodeCov (8)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Server / UT & CodeCov (8)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Server / UT & CodeCov (17)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
|
Server / UT & CodeCov (11)
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
StaticAnalysis
|
922 KB |
sha256:9345b7b903e2baee138996211239f0d8cc25afad2e23f48973bdb8a02e4db0c2
|
|
|
clients-jdk11
|
3.03 MB |
sha256:95a44818b0125aed53875fd7385041deb9613a5ec127737907d7be585152f16f
|
|
|
clients-jdk17
|
3.05 MB |
sha256:85b8d85e5e8dc3f0383ef4732b3f299ca78b88f1a48e9fc90b008aa9a2e0183c
|
|
|
clients-jdk8
|
2.98 MB |
sha256:3ea6a6c566447ac53b5bb1dbd0fb2f113b4718965cdbfc06ed9d10dad592932a
|
|
|
controller-jdk11
|
2 MB |
sha256:ddb640104b46ead1f1de7cb00e45bffbdd1e6f4eb3853165ed4c2b83b6575f7e
|
|
|
controller-jdk17
|
2 MB |
sha256:aef5f6f62070799c89108eee455f6a990e82223cc20f96a6d898c223ba47d4f1
|
|
|
controller-jdk8
|
1.99 MB |
sha256:18d62b21f6c237931401bac755f166788bcc025c52b60ac7b91e93e432592380
|
|
|
integrations-jdk11
|
607 KB |
sha256:5987cfa4d6392f451de0d7bba31ce48a122ada50cf70844611923530e9513675
|
|
|
integrations-jdk17
|
612 KB |
sha256:04db7b27760520f41141a85d7ee5faa24764b5c8cbc7bb6533b6d82062b3891f
|
|
|
integrations-jdk8
|
594 KB |
sha256:c40b737db9eaab7b8196984c6d20485ab163f85c90c0826a9159fa50903b3f82
|
|
|
internal-jdk11
|
4.17 MB |
sha256:b3c7abfe5056997add22c13267ce408e03aaca3ca3ccc19a2456f7588f0b6ce4
|
|
|
internal-jdk17
|
4.19 MB |
sha256:db2c3b2eca0716fe6c1aa7ecc06d2edc505b61c4534c68e20c3c130b6e3ddcc2
|
|
|
internal-jdk8
|
4.16 MB |
sha256:42892810226ef2b8c6b75dee5375f251591acbc18c66f8fb0eb6339ebc7f1cfe
|
|
|
router-jdk11
|
781 KB |
sha256:160d438505d8f15ba13bef8c2078d2fa1a5efee69e27ada71cc87fd9fa06cebc
|
|
|
router-jdk17
|
784 KB |
sha256:2f6aff239852358bd16fa4e39e3f83afc9f27b9d6a4b1deb19ae9e82c2eba5b7
|
|
|
router-jdk8
|
772 KB |
sha256:593e79c022798994b161defe99f00d3167d51d1c32b517a1053e4732061d4d32
|
|
|
server-jdk11
|
10.2 MB |
sha256:6e96474173f4581ac47a75fe108690390a962f589ea3671bd561ec112a1eba60
|
|
|
server-jdk17
|
10.3 MB |
sha256:e6f01602096200c78096b7414740e7f4e5a233ec8961d9e0cc10077d7a4cdef2
|
|
|
server-jdk8
|
10.3 MB |
sha256:759166c219fa1151532832fba9cdac3cc132642e0209acfb7f309293cf30b165
|
|