Notify on keydown

[inquirer5]

Adding ability to run actions based on keydown/keyup if specified, otherwise it retains the original behavior.

• Added includeAction parameter to turn on additional action data
• Added connected status indicator to node on flow ui
• Switched from console.log to official logging methods
• Attempt reconnect on lost connection (seems to occur randomly, possibly on bridge auto-updates)
• Closes Issue Typo #8

[lilyball]

Won't this run done() a second time if the end() succeeds and the first done() throws an exception?

[inquirer5]

No, done shouldn't throw an exception since it's a callback provided by nodered. The catch is in case the end() throws an exception to ensure we still force the cleanup and call done().

[lilyball]

It shouldn't throw, but you don't control nodered's code. This would be safer and simpler to write as

Suggested change

	node.telnet.end()
	.then(() => done())
	.catch(() => this.telnet.destroy().then(() => done()));
	node.telnet.end()
	.catch(() => this.telnet.destroy())
	.then(() => done());

This way an exception from done() won't cause it to repeat (or to call destroy()), and you're not repeating the callback either.

Also, question: What happens if destroy() throws an exception? Neither version of the code will call done() in that case. Maybe it should? If it should, then my version would use .finally(() => done()) instead (or just .finally(done) as finally already passes no arguments).

[inquirer5]

Ah, forgot finally was available with promises. Thanks, I'll update.

[lilyball]

This should likely test || (value === 4 && node.sendObj). I know the only documented actions for pico remotes are 3 and 4 but that's no reason to make assumptions.

[lilyball]

Pre-existing issue, but this is missing Button 2 (a=3), and it's also missing the buttons for the PJ2-4B model (8/9/10/11), which is rather a problem as that's the model I have 😅