Skip to content

feat: added style to login form #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

brettearle
Copy link

Not sure if this is needed but it adds a consistency to the demo app. Happy to do other pages of lucia demo if styling is needed.

Screenshot from 2025-04-14 06-55-41

Copy link

changeset-bot bot commented Apr 13, 2025

⚠️ No Changeset found

Latest commit: da9b4f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@brettearle brettearle changed the title Added style to login form feat: added style to login form Apr 13, 2025
Copy link

pkg-pr-new bot commented Apr 18, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@535
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@535

commit: 80a1842

@manuel3108
Copy link
Member

Hmmm, not too sure about this one. Generally I like the idea, since especially since when you add tailwindcss and lucia at the same time, you are greeted with a horrible looking page:
image

If you don't add tailwind, I think the demo works as expected and does not need any adjustment. That's why I would suggest just adding a few tailwindcss classes to make it work with tailwind as well. Here is an example of what i mean:

<h1>Login/Register</h1>
<form method="post" action="?/login" use:enhance>
    <label>
        Username
        <input class="border" name="username" />
    </label>
    <label>
        Password
        <input class="border" type="password" name="password" />
    </label>
    <button
        class="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded"
        >Login</button
    >
    <button
        class="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded"
        formaction="?/register">Register</button
    >
</form>
<p style="color: red">{form?.message ?? ''}</p>

image

What do you think about this?

@brettearle
Copy link
Author

@manuel3108 yeah I can do that, I don't use the tailwind add-on and thought the login page was pragmatic but not refined like rest of the demo.
I'll add the tailwind classes instead of base styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants