Skip to content

fix: Always add Storybook last #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025

Conversation

JReinhold
Copy link
Contributor

Ensure that if Storybook is selected during creation, it is always added after the other addon.

See Side note in #497 (comment) for context

Copy link

changeset-bot bot commented Apr 24, 2025

🦋 Changeset detected

Latest commit: 7344eff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 24, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@547
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@547

commit: 7344eff

@manuel3108
Copy link
Member

We used to have #86 which would have been perfect in this case. I think we should only implement the proposed solution if we don't find a better way before summit. Let me see if we can re-introduce something similar to what we had before

@JReinhold
Copy link
Contributor Author

JReinhold commented Apr 24, 2025

I see, makes sense to me. I played around with dependsOn at first, but it wasn't the right fit here.

Could we temporarily merge this in? As even today with the existing versions, users will get a broken setup out of the box, which is not a nice experience.

@manuel3108
Copy link
Member

Sounds good, opened #550 for the full implementation of runsAfter

@manuel3108 manuel3108 merged commit 8cdab6c into sveltejs:main Apr 25, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants