feat: add no-add-event-listener rule
#1197
Conversation
|
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
| docs: { | ||
| description: 'Warns against the use of `addEventListener`', | ||
| category: 'Best Practices', | ||
| recommended: false, |
There was a problem hiding this comment.
Do you think this should be shipped as a recommended rule? (It might cause a lot of errors in existing code, though.)
cc: @ota-meshi
There was a problem hiding this comment.
ultimately i think it should be recommended, but im not sure how we can do that without introducing loads of errors like you say 🤔 it'd have to be in the next major i suppose
| window.addEventListener ('message', handler); | ||
| // with a comment | ||
| window.addEventListener/* foo */('message', handler); |
There was a problem hiding this comment.
Should we also include the TypeScript case like this?
(window as any).addEventListener ('message', handler);
(window.addEventListener as any)('message', handler);There was a problem hiding this comment.
for this one, i added the test cases but this one isn't currently supported:
(window.addEventListener as any)('message', handler);we would need logic to handle call expressions containing casts, which feels weird. maybe we should just ignore this case and not try handle it?
.../eslint-plugin-svelte/tests/fixtures/rules/no-add-event-listener/invalid/test01-input.svelte
Show resolved
Hide resolved
43081j
force-pushed
the
listeners-and-such
branch
from
a11babd to
e13635b
Compare
this helped me learn about the events helpers, so figured i may as well throw it together.
let me know if there's anything i missed, as i don't think i've added a new rule in this repo before.
one thing to note is that it has a suggestion, but that relies on the user later making sure
onhas been imported correctly. im not sure we can do that automatically since each suggestion runs individually and should probably only affect the subset of code you're reportingclose: #1194