-
-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add svelte/no-top-level-browser-globals
rule
#1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 61bb8af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<script lang="ts">
const a = () => {
console.log(location.href);
}
a();
</script> I think it would be difficult to support that with this rule 😅 |
6d06e29
to
15b672a
Compare
15b672a
to
61bb8af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
close #1203
I have implemented the rule but there are still many test cases missing.I have a question: #1203 (comment)