Skip to content

Update paper.svg filler for 7.01 & 7.03 #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

maxmynter
Copy link
Contributor

@maxmynter maxmynter commented Apr 21, 2024

as was done in #502 for tutorial exercises 7.02. With fill="none", the business card paper background is not rendered. This PR changes to fill="white" in 7.01 and 7.03.

(Really enjoying the tutorial and Svelte in general so far. Thanks for all your work).

as was done in 8ded6c5 for 7.02.
With fill="none", the business card paper background is not rendered
correctly.
Copy link

vercel bot commented Apr 21, 2024

@maxmynter is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@maxmynter
Copy link
Contributor Author

@Rich-Harris the bug is still live on learn.svelte.dev :)
If adjustments to my submission are necessary, I'd appreciate guidance and will fix it.

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 3:44pm

Copy link
Member

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@geoffrich geoffrich merged commit c1e1157 into sveltejs:main Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants