fix: prevent overlay flash when closing iOS mobile nav menu (#1548)#1894
Open
AbdullahShafqat-OG wants to merge 2 commits into
Open
fix: prevent overlay flash when closing iOS mobile nav menu (#1548)#1894AbdullahShafqat-OG wants to merge 2 commits into
AbdullahShafqat-OG wants to merge 2 commits into
Conversation
|
@AbdullahShafqat-OG is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AbdullahShafqat-OG
force-pushed
the
ios-nav-overlay-flash
branch
from
b9b1d44 to
10d9937
Compare
AbdullahShafqat-OG
force-pushed
the
ios-nav-overlay-flash
branch
2 times, most recently
from
9f12999 to
dc72848
Compare
AbdullahShafqat-OG
force-pushed
the
ios-nav-overlay-flash
branch
from
dc72848 to
fb4ae0b
Compare
AbdullahShafqat-OG
force-pushed
the
ios-nav-overlay-flash
branch
from
fb4ae0b to
97bc295
Compare
Member
|
Sorry for taking a long time to look at this. I've tested on the latest iOS and this doesn't seem to be an issue anymore |
Contributor
Author
|
@teemingc I just tried with iOS 26.0.1 on iPhone 15 and still flashes for me. Perhaps it does not show up in a later version of iOS. Should it still be addressed perhaps to fix in previous iOS versions as well? |
Member
|
You’re right. I’m wondering if we can preserve the quick transition on menu close though. Is the flash caused by the 100ms transition duration? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a visual glitch where the overlay briefly flashes when closing the mobile navigation menu.
The issue was caused by a discrepancy in transition durations between
MobileMenuandModalOverlay.The transition timing has been streamlined by defining it in
MobileMenuand passing it down as a prop toModalOverlay. This ensures both components stay in sync and eliminates the visual inconsistency.Fixes #1548
Before
before.mp4
After
after.mp4