Skip to content

feat: only traverse trailing static nodes during hydration #12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

Rich-Harris
Copy link
Member

Alternative to #12932 — we continue traversing if hydrating (which is annoying, but allows the mismatch detection to continue working) but not if mounting. If the app never hydrates, the $.next(...) line will be treeshaken.

If we find an elegant way to skip traversal in hydration in cases like #12932 then that would be even better, but this is a useful improvement in its own right.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 8e28d5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Rich-Harris Rich-Harris merged commit cadc0dc into main Aug 22, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the replace-trailing-sibling-with-next branch August 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants