Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add snippet argument validation in dev #15521

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Ocean-OS
Copy link
Contributor

@Ocean-OS Ocean-OS commented Mar 15, 2025

Fixes #15517 by throwing in dev mode if a snippet is passed invalid arguments— in client, if $$anchor is not a Node or other arguments are not functions, and in server, if $$payload is not a valid payload.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 15, 2025

🦋 Changeset detected

Latest commit: 31b4bb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15521

Copy link
Contributor

@HoldYourWaffle HoldYourWaffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast!
Small mixup: this'd fix #15517, #15518 adds a note about it to the docs :)

@Ocean-OS
Copy link
Contributor Author

This should be ready for review. I made Payload a class and changed any references to it to reflect this.

@Ocean-OS
Copy link
Contributor Author

Ocean-OS commented Apr 1, 2025

Not sure why tests are failing all of a sudden, they were passing before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking a Snippet outside @render gives unhelpful error message
4 participants