Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset overlay content when Reveal composable is disposed #197

Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix: reset overlay content when Reveal composable is disposed #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions reveal-core/src/commonMain/kotlin/com/svenjacobs/reveal/Reveal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.compose.foundation.gestures.detectTapGestures
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.derivedStateOf
import androidx.compose.runtime.getValue
Expand Down Expand Up @@ -158,6 +159,14 @@ public fun Reveal(
}
}
}

// When the Reveal composable is disposed we need to reset overlayContent or else the effect
// might remain on the screen (issue #196).
DisposableEffect(Unit) {
onDispose {
revealCanvasState.overlayContent = null
}
}
}

public typealias OnClickListener = (key: Key) -> Unit
Expand Down
Loading