-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog edit and fuzz for #139 #143
Conversation
67ecdfb
to
e046074
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 49.81% 48.72% -1.09%
==========================================
Files 17 17
Lines 1347 1377 +30
==========================================
Hits 671 671
- Misses 676 706 +30 ☔ View full report in Codecov by Sentry. |
22063db
to
e3fd6fe
Compare
b8bc24d
to
8a89a0c
Compare
8a89a0c
to
75eb259
Compare
toolchain: nightly | ||
# use a known good version (e.g. on Jan 14 2025, a faulty `rustc` nightly panicked) | ||
toolchain: nightly-2024-01-13 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I think it's good for the ecosystem to always run the latest nightly. We will otherwise definitely forget to upgrade. Hard regressions usually get fixed quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good for the ecosystem to always run the latest nightly.
Yes, it is possible to sacrifice reliability on our end to increase the chance that we find (and report?) issues to upstream rustc
for the benefit of the ecosystem.
Never upgrading is also a bad policy, as eventual developments in locally-installed nightly
Rust will produce code that doesn't work on the CI's version.
I personally view the harms of rustc
-roulette to be greater, as it creates collateral damage to unrelated PR's. Never upgrading only risks errors when updating the fuzzer itself.
A real solution might involve trying the latest and producing a warning while falling back to a known good version if it doesn't work, but it seems complex to implement in CI.
I'll merge, but I'll make a tracking issue to help avoid forgetting about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
Followup to #139
Noticed #140 (infinity this time, not NaN), which needs a new fix, but that's orthogonal (only affects near-miss rays, so I simply restrict the new assertions to
Mode::Grid
)I intend to wait ~24h before merging, just in case there are any comments/suggestions/objections.