Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RabbitMQ as message queue solution #895

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

svix-gabriel
Copy link
Contributor

@svix-gabriel svix-gabriel commented Apr 18, 2023

Motivation

This adds RabbitMQ as an alternative internal queueing system (instead of in-memory or redis based queueing).

That's pretty much it. The RabbitMQ integration has only been tested locally using E2E tests, so there may be issues that only show up on a larger scale that need addressing. As such, this should be treated as an MVP. Be cautious about using the RabbitMQ solution in a production environment for the time being. The README hasn't been updated yet for precisely this reason.

Solution

All in all, this requires a few changes

  • Adding the integration to the local docker-compose testing suite. There's an adjacent rabbit folder for including the delayed message plugin, for, well, sending delayed messages 😃
  • Adding the actual queue implementation
  • The test that checks multiple concurrent workers was updated to ack messages.

@svix-gabriel svix-gabriel force-pushed the gabriel/rabbitmq branch 9 times, most recently from f6c583c to a8a640a Compare April 18, 2023 18:20
@svix-gabriel svix-gabriel marked this pull request as ready for review April 18, 2023 18:42
@svix-gabriel svix-gabriel merged commit 12b8bbe into main Apr 19, 2023
@svix-gabriel svix-gabriel deleted the gabriel/rabbitmq branch April 19, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants